Skip to content

ingress access logging toggle added #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alvlkov
Copy link

@alvlkov alvlkov commented Apr 22, 2025

What type of PR is this?

feature

What this PR does / Why we need it?

This script provides a toggle for enabling/disabling ingress access logging within the default ingress

Which Jira/Github issue(s) does this PR fix?

_Resolves #OSD-23991

Special notes for your reviewer

Validated within stage Classic ROSA
Verified logs container is created/removed when toggle is set accordingly.

Pre-checks (if applicable)

  • Validated the changes in a cluster
  • Included documentation changes with PR

Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alvlkov
Once this PR has been reviewed and has the lgtm label, please assign mitalibhalla for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@alvlkov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant