Skip to content

OSD-19235:Adding Contributing.md #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

MitaliBhalla
Copy link
Contributor

@MitaliBhalla MitaliBhalla commented Mar 25, 2025

What type of PR is this?

documentation
(bug/feature/cleanup/documentation)

What this PR does / Why we need it?

This PR adds a document on guidelines and best practices for contributing to managed-scripts

Which Jira/Github issue(s) does this PR fix?

OSD-19235.
This PR is an extension/take over from Abhishek Sheth's PR https://github.com/ASheth1/managed-scripts/blob/main/CONTRIBUTING.md
I have taken over this task as his secondment is over.

Resolves #
OSD-19235

Special notes for your reviewer

Pre-checks (if applicable)

  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2025

@MitaliBhalla: This pull request references OSD-19235 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

What type of PR is this?

documentation
(bug/feature/cleanup/documentation)

What this PR does / Why we need it?

This PR adds a document on guidelines and best practices for contributing to managed-scripts

Which Jira/Github issue(s) does this PR fix?

OSD-19235.
This PR is an extension/take over from Abhishek Sheth's PR https://github.com/ASheth1/managed-scripts/blob/main/CONTRIBUTING.md
I have taken over as his secondment is over.

Resolves #
OSD-19235

Special notes for your reviewer

Pre-checks (if applicable)

  • Validated the changes in a cluster
  • Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from feichashao and xiaoyu74 March 25, 2025 06:14
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MitaliBhalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2025
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

@MitaliBhalla: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Dee-6777
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 676cddb into openshift:main Mar 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants