Skip to content

OCPBUGS-59543: Watch openshift-config CMs #5181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-59543: Watch openshift-config CMs #5181

wants to merge 1 commit into from

Conversation

pablintino
Copy link
Contributor

Closes: OCPBUGS-59543

- What I did

This commit adds a watcher for ConfigMaps in the openshift-config namespace as we consume CMs from that namespace to, for example, load CA certificates. If the user perform a change in one of those certificates we do not see the change and only a restart of the controller pod can reload the ConfigMap content.

- How to verify it

- Description for the changelog
Adds a ConfigMap watcher for the openshift-config namespace.

@pablintino
OCPBUGS-59543: Wath openshift-config CMs
83606bb 
This commit adds a watcher for ConfigMaps in the openshift-config
namespace as we consume CMs from that namespace to, for example, load
CA certificates. If the user perform a change in one of those
certificates we do not see the change and only a restart of the
controller pod can reload the ConfigMap content.
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 21, 2025
@openshift-ci-robot
Copy link
Contributor

@pablintino: This pull request references Jira Issue OCPBUGS-59543, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Closes: OCPBUGS-59543

- What I did

This commit adds a watcher for ConfigMaps in the openshift-config namespace as we consume CMs from that namespace to, for example, load CA certificates. If the user perform a change in one of those certificates we do not see the change and only a restart of the controller pod can reload the ConfigMap content.

- How to verify it

- Description for the changelog
Adds a ConfigMap watcher for the openshift-config namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pablintino
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 21, 2025
@openshift-ci-robot
Copy link
Contributor

@pablintino: This pull request references Jira Issue OCPBUGS-59543, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 21, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 21, 2025

@pablintino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade-single-node 83606bb link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-gcp-single-node 83606bb link false /test e2e-gcp-single-node
ci/prow/e2e-aws-serial 83606bb link false /test e2e-aws-serial
ci/prow/e2e-aws-disruptive 83606bb link false /test e2e-aws-disruptive
ci/prow/e2e-ovirt 83606bb link false /test e2e-ovirt
ci/prow/okd-e2e-upgrade 83606bb link false /test okd-e2e-upgrade
ci/prow/e2e-gcp-op-ocl 83606bb link false /test e2e-gcp-op-ocl
ci/prow/e2e-openstack-parallel 83606bb link false /test e2e-openstack-parallel
ci/prow/okd-e2e-gcp-op 83606bb link false /test okd-e2e-gcp-op
ci/prow/e2e-metal-assisted 83606bb link false /test e2e-metal-assisted
ci/prow/e2e-metal-ipi-ovn-dualstack 83606bb link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-agent-compact-ipv4 83606bb link false /test e2e-agent-compact-ipv4
ci/prow/e2e-gcp-upgrade 83606bb link false /test e2e-gcp-upgrade
ci/prow/okd-scos-e2e-aws-ovn 83606bb link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-ovirt-upgrade 83606bb link false /test e2e-ovirt-upgrade
ci/prow/e2e-aws-ovn-workers-rhel8 83606bb link false /test e2e-aws-ovn-workers-rhel8
ci/prow/e2e-azure-ovn-upgrade 83606bb link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-openstack-externallb 83606bb link false /test e2e-openstack-externallb
ci/prow/e2e-metal-ipi-ovn-ipv6 83606bb link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/okd-e2e-vsphere 83606bb link false /test okd-e2e-vsphere
ci/prow/okd-e2e-aws 83606bb link false /test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel8 83606bb link false /test e2e-aws-workers-rhel8
ci/prow/okd-images 83606bb link true /test okd-images
ci/prow/e2e-azure-ovn-upgrade-out-of-change 83606bb link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@djoshy
Copy link
Contributor

djoshy commented Jul 21, 2025

Looks good to me, holding for QE review

/hold

/approve

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2025
@umohnani8
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, pablintino, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [djoshy,pablintino,umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pablintino pablintino changed the title OCPBUGS-59543: Wath openshift-config CMs OCPBUGS-59543: Watch openshift-config CMs Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

@djoshy djoshy Awaiting requested review from djoshy

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@umohnani8 umohnani8

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablintino @openshift-ci-robot @djoshy @umohnani8