Skip to content

NO-ISSUE: API & client-go version bumps #5142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NO-ISSUE: API & client-go version bumps #5142

wants to merge 2 commits into from
+9,128 −7,842

Conversation

isabella-janssen
Copy link
Member

- What I did
Bump the API dependency to openshift/api@a8cbc21 & the client-go dependency to openshift/client-go@7b20078.

- How to verify it
Tests should pass.

- Description for the changelog
NO-ISSUE: API & client-go version bumps

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 24, 2025
@openshift-ci-robot
Copy link
Contributor

@isabella-janssen: This pull request explicitly references no jira issue.

In response to this:

- What I did
Bump the API dependency to openshift/api@a8cbc21 & the client-go dependency to openshift/client-go@7b20078.

- How to verify it
Tests should pass.

- Description for the changelog
NO-ISSUE: API & client-go version bumps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@isabella-janssen isabella-janssen marked this pull request as ready for review June 24, 2025 20:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2025
@isabella-janssen isabella-janssen changed the title NO-ISSUE: NO-ISSUE: API & client-go version bumps Jun 24, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@isabella-janssen
Copy link
Member Author

/hold

We will wait to merge this until after #5108 lands.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2025
yuqi-zhang
yuqi-zhang approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [isabella-janssen,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isabella-janssen
Copy link
Member Author

/unhold

#5108 landed

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2025
@isabella-janssen
Copy link
Member Author

/retest-required

1 similar comment
@isabella-janssen
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 36a1298 and 2 for PR HEAD 75a4864 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 26, 2025

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op 75a4864 link true /test e2e-gcp-op
ci/prow/e2e-azure-ovn-upgrade-out-of-change 75a4864 link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 36a1298 and 2 for PR HEAD 75a4864 in total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@dkhater-redhat dkhater-redhat Awaiting requested review from dkhater-redhat

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isabella-janssen @openshift-ci-robot @yuqi-zhang