Skip to content

MGMT-20810: pass control plane topology to keepalived-monitor #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

giladravid16
Copy link

@giladravid16 giladravid16 commented Jun 8, 2025

- What I did

Pass control plane topology to keepalived-monitor

- How to verify it

I installed a cluster with this and saw it take affect

- Description for the changelog

Pass control plane topology to keepalived-monitor

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2025
Copy link
Contributor

openshift-ci bot commented Jun 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Jun 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: giladravid16
Once this PR has been reviewed and has the lgtm label, please assign rishabhsaini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giladravid16 giladravid16 force-pushed the add_topology_keepalived branch from 279d60b to 94c8d82 Compare June 8, 2025 13:02
@giladravid16 giladravid16 force-pushed the add_topology_keepalived branch from 94c8d82 to f294543 Compare June 9, 2025 08:05
@giladravid16 giladravid16 changed the title WIP: pass control plane topology to keepalived-monitor MGMT-20810: pass control plane topology to keepalived-monitor Jun 9, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 9, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 9, 2025

@giladravid16: This pull request references MGMT-20810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 9, 2025

@giladravid16: This pull request references MGMT-20810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did

Pass control plane topology to keepalived-monitor

- How to verify it

I installed a cluster with this and saw it take affect

- Description for the changelog

Pass control plane topology to keepalived-monitor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@giladravid16 giladravid16 marked this pull request as ready for review June 9, 2025 08:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2025
@giladravid16
Copy link
Author

giladravid16 commented Jun 9, 2025

/hold

This should be merged after openshift/baremetal-runtimecfg#348 which will add the --control-plane-topology arg

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2025
@openshift-ci openshift-ci bot requested review from jcpowermac and mandre June 9, 2025 08:10
Copy link
Contributor

openshift-ci bot commented Jun 9, 2025

@giladravid16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview f294543 link false /test e2e-gcp-op-techpreview
ci/prow/e2e-gcp-op f294543 link true /test e2e-gcp-op
ci/prow/e2e-openstack f294543 link false /test e2e-openstack
ci/prow/e2e-azure-ovn-upgrade-out-of-change f294543 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-single-node f294543 link true /test e2e-gcp-op-single-node
ci/prow/e2e-agent-compact-ipv4 f294543 link false /test e2e-agent-compact-ipv4
ci/prow/e2e-gcp-op-ocl f294543 link false /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pablintino
Copy link
Contributor

@giladravid16 Hi, let me know when openshift/baremetal-runtimecfg#348 is merged to have a look. So far, it looks good to me with that change in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants