-
Notifications
You must be signed in to change notification settings - Fork 435
MGMT-20810: pass control plane topology to keepalived-monitor #5113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: giladravid16 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
279d60b
to
94c8d82
Compare
94c8d82
to
f294543
Compare
@giladravid16: This pull request references MGMT-20810 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@giladravid16: This pull request references MGMT-20810 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold This should be merged after openshift/baremetal-runtimecfg#348 which will add the --control-plane-topology arg |
@giladravid16: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@giladravid16 Hi, let me know when openshift/baremetal-runtimecfg#348 is merged to have a look. So far, it looks good to me with that change in place. |
- What I did
Pass control plane topology to keepalived-monitor
- How to verify it
I installed a cluster with this and saw it take affect
- Description for the changelog
Pass control plane topology to keepalived-monitor