-
Notifications
You must be signed in to change notification settings - Fork 425
OCPBUGS-55681: Give keepalived container chroot cap #5032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
When we switched our containers to use capabilities intead of giving them full admin access to everything, we missed that the keepalived container needs to be able to chroot for one of its health checks. Because this check is always failing now, we may place the VIP incorrectly and break access to ingress services on the cluster. This just adds the necessary capability to the container. There will be a followup change in the origin repo to add a test that would have caught this, since it's not a problem in a normal CI run.
@cybertron: This pull request references Jira Issue OCPBUGS-55681, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cybertron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@cybertron: This pull request references Jira Issue OCPBUGS-55681, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
/retest-required This is not used in aws. |
@cybertron: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
When we switched our containers to use capabilities intead of giving them full admin access to everything, we missed that the keepalived container needs to be able to chroot for one of its health checks. Because this check is always failing now, we may place the VIP incorrectly and break access to ingress services on the cluster. This just adds the necessary capability to the container.
There will be a followup change in the origin repo to add a test that would have caught this, since it's not a problem in a normal CI run.
- What I did
- How to verify it
- Description for the changelog