Skip to content

OCPBUGS-55681: Give keepalived container chroot cap #5032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cybertron
Copy link
Member

When we switched our containers to use capabilities intead of giving them full admin access to everything, we missed that the keepalived container needs to be able to chroot for one of its health checks. Because this check is always failing now, we may place the VIP incorrectly and break access to ingress services on the cluster. This just adds the necessary capability to the container.

There will be a followup change in the origin repo to add a test that would have caught this, since it's not a problem in a normal CI run.

- What I did

- How to verify it

- Description for the changelog

When we switched our containers to use capabilities intead of giving
them full admin access to everything, we missed that the keepalived
container needs to be able to chroot for one of its health checks.
Because this check is always failing now, we may place the VIP
incorrectly and break access to ingress services on the cluster.
This just adds the necessary capability to the container.

There will be a followup change in the origin repo to add a test that
would have caught this, since it's not a problem in a normal CI run.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 5, 2025
@openshift-ci-robot
Copy link
Contributor

@cybertron: This pull request references Jira Issue OCPBUGS-55681, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When we switched our containers to use capabilities intead of giving them full admin access to everything, we missed that the keepalived container needs to be able to chroot for one of its health checks. Because this check is always failing now, we may place the VIP incorrectly and break access to ingress services on the cluster. This just adds the necessary capability to the container.

There will be a followup change in the origin repo to add a test that would have caught this, since it's not a problem in a normal CI run.

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from patrickdillon and rvanderp3 May 5, 2025 16:26
Copy link
Contributor

openshift-ci bot commented May 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cybertron
Once this PR has been reviewed and has the lgtm label, please assign cheesesashimi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cybertron
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 5, 2025
@openshift-ci-robot
Copy link
Contributor

@cybertron: This pull request references Jira Issue OCPBUGS-55681, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi May 5, 2025 16:43
@cybertron
Copy link
Member Author

/retest-required

@cybertron
Copy link
Member Author

/retest-required

This is not used in aws.

Copy link
Contributor

openshift-ci bot commented May 8, 2025

@cybertron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade-out-of-change faaf300 link false /test e2e-aws-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-ocl faaf300 link false /test e2e-gcp-op-ocl
ci/prow/e2e-azure-ovn-upgrade-out-of-change faaf300 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-aws-ovn faaf300 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants