Skip to content

MCO-1661: Feature Gate handling rework #5029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MCO-1661: Feature Gate handling rework #5029

wants to merge 1 commit into from

Conversation

pablintino
Copy link
Contributor

- What I did

- How to verify it

- Description for the changelog

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pablintino pablintino changed the title MCO-1661 Feature Gate handling rework MCO-1661: Feature Gate handling rework May 5, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 5, 2025 •
edited by openshift-ci bot
Loading

@pablintino: This pull request references MCO-1661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pablintino
Once this PR has been reviewed and has the lgtm label, please assign djoshy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pablintino pablintino force-pushed the featuregate-handler-rework branch 4 times, most recently from 98d0cad to eec056e Compare May 6, 2025 12:50
@pablintino pablintino marked this pull request as ready for review May 6, 2025 13:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2025
@openshift-ci openshift-ci bot requested review from sohankunkerkar and umohnani8 May 6, 2025 13:50
@pablintino pablintino force-pushed the featuregate-handler-rework branch from eec056e to c896109 Compare May 6, 2025 13:50
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 6, 2025 •
edited
Loading

@pablintino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn c896109 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-upgrade-out-of-change c896109 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-ocl c896109 link false /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pablintino
Copy link
Contributor Author

/test e2e-hypershift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablintino @openshift-ci-robot