OCPBUGS-55450: Only populate Status.PinnedImageSets.CurrentGeneration on valid generation value
#5023
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
isabella-janssen
changed the title
Status.PinnedImageSets.CurrentGeneration on valid generation value
openshift-ci-robot
added
jira/severity-important
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-55450, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-55450, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
… reference in MCN when the value is valid
isabella-janssen
force-pushed
the
ocpbugs-55450
branch
from
b36bece to
8ba4f20
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial #5034 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f7107030-2acc-11f0-85d1-2b41fb50677b-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial #5034 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e57d3e0-2acd-11f0-8c8e-ee3d28450af1-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial #5034 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/29dbd360-2acd-11f0-944c-1a7023fa619a-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial #5034 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3ceb9620-2acd-11f0-8f67-4e7e524cbd0e-0 |
|
@isabella-janssen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
|
@isabella-janssen: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6002f400-2b36-11f0-834f-819f1d385f81-0 |
|
/retest-required |
|
/lgtm Nice work debugging this! 😄 /hold for QE but feel free to unhold if not required |
openshift-ci
bot
added
the
do-not-merge/hold
|
I do not have all the required context but I'd say lgtm based on the Jira card |
|
Pre-merge verification steps:
Example$ oc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfigPool
metadata:
name: infra
spec:
machineConfigSelector:
matchExpressions:
- {key: machineconfiguration.openshift.io/role, operator: In, values: [worker,infra]}
nodeSelector:
matchLabels:
node-role.kubernetes.io/infra: ""
EOF
$ oc label node/ip-10-0-108-115.us-east-2.compute.internal node-role.kubernetes.io/infra=2. Apply Valid PIS Exampleoc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
labels:
machineconfiguration.openshift.io/role: infra
name: pinned-images
spec:
pinnedImages:
- name: "quay.io/openshifttest/busybox@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a614f24736e8eef41a4591f08019"
- name: quay.io/openshifttest/alpine@sha256:be92b18a369e989a6e86ac840b7f23ce0052467de551b064796d67280dfa06d5
EOF
$ oc describe machineconfignode ip-10-0-108-115.us-east-2.compute.internal
Last Transition Time: 2025-05-07T16:34:18Z
Message: All pinned image sets complete
Reason: AsExpected
Status: False
Type: PinnedImageSetsProgressing
.....
Last Transition Time: 2025-05-07T16:34:18Z
Message: All is good
Reason: AsExpected
Status: False
Type: PinnedImageSetsDegraded
.....
Pinned Image Sets:
Current Generation: 1
Desired Generation: 1
Name: pinned-images
4. Apply Invalid PIS
Exampleoc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
labels:
machineconfiguration.openshift.io/role: infra
name: pinned-bad-image
spec:
pinnedImages:
- name: "quay.io/openshiftfake/fakeimage@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a614f24736e8eef41a4591f08019"
EOF
oc describe machineconfignode ip-10-0-108-115.us-east-2.compute.internal | tail -n 10
....
Last Transition Time: 2025-05-07T16:44:28Z
Message: node is prefetching images: ip-10-0-108-115.us-east-2.compute.internal
Reason: ImagePrefetch
Status: True
Type: PinnedImageSetsProgressing
.....
Last Transition Time: 2025-05-07T16:44:28Z
Message: One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details
Reason: PrefetchFailed
Status: True
Type: PinnedImageSetsDegraded
.....
Config Version:
Current: rendered-infra-bbb24207a4af065d3c0b012e1c58d912
Desired: rendered-infra-bbb24207a4af065d3c0b012e1c58d912
Observed Generation: 5
Pinned Image Sets:
Desired Generation: 1
Last Failed Generation: 1
Last Failed Generation Error: failed to execute podman manifest inspect for "quay.io/openshiftfake/fakeimage@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a614f24736e8eef41a4591f08019": exit status 125
Name: pinned-bad-image
Events:
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
|
@isabella-janssen: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2e78d050-2b6b-11f0-8d07-4614b6dbccbb-0 |
There was a problem hiding this comment.
Logically lgtm.
Interestingly, the payload run has some failures with some MCO related issues, with the vsphere one failing on Should properly transition through MCN conditions on rebootless node update and the AWS failing on MCO related events. They don't seem related to this PR, but are we concerned about those?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, isabella-janssen, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yuqi-zhang Yeah, I saw those failures yesterday in the morning and decided to run the payload tests again to see if it's consistent or if it seemed like a flake. What's most concerning to me is the AWS blocking job failing on That being said, none of the issues seem like they would be results of changes in this PR. 🤔 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.20-e2e-azure-ovn-techpreview periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-techpreview-serial |
|
@isabella-janssen: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/93780a00-2c0d-11f0-9626-d0146da4ac88-0 |
|
/unhold The payload rehearsal tests against the 4.20 periodic jobs looked good. None of the failures related to PIS or MCN, so this PR should be safe to merge. |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit 647e51e
into
openshift:main
|
@isabella-janssen: Jira Issue OCPBUGS-55450: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-55450 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.19 |
|
@isabella-janssen: new pull request created: #5039 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Closes: OCPBUGS-55450
- What I did
This adds a check to only set
Status.PinnedImageSets.CurrentGenerationin a MachineConfigNode object when the generation value is valid, or non-zero.- How to verify it
Example Invalid PIS targeting "custom" MCP
apiVersion: machineconfiguration.openshift.io/v1 kind: PinnedImageSet metadata: name: test-pinned labels: machineconfiguration.openshift.io/role: "custom" spec: pinnedImages: - name: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:86d26e7ebcccd6f07a75db5b1e56283b25c2ee1c6a755d6ffc5a4d59beb9cdefExample valid PIS targeting "custom" MCP
apiVersion: machineconfiguration.openshift.io/v1 kind: PinnedImageSet metadata: name: test-pinned labels: machineconfiguration.openshift.io/role: "custom" spec: pinnedImages: - name: quay.io/openshifttest/busybox@sha256:c5439d7db88ab5423999530349d327b04279ad3161d7596d2126dfb5b02bfd1Name,DesiredGeneration, andCurrentGeneration.Note: To see the original failures, see this example payload job: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-config-operator-5034-ci-4.19-e2e-gcp-ovn-techpreview-serial/1919889377152995328.
- Description for the changelog
OCPBUGS-55450: Only populate
Status.PinnedImageSets.CurrentGenerationon valid generation value