OCPBUGS-55439: scope MCD node listers to current node

[cheesesashimi]

- What I did

Each node in the cluster was also listing all of the other nodes within the cluster and we were filtering out irrelevant nodes manually. Instead, a much better approach is to have the informer filter the node at the API server level to reduce load on the API server. This is mostly a problem for clusters with 1200+ nodes.

- How to verify it

The MCD should continue to work as-is.

- Description for the changelog
MCD node listers should only be scoped to the node they're running on

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@cheesesashimi: This pull request references Jira Issue OCPBUGS-55439, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did

Each node in the cluster was also listing all of the other nodes within the cluster and we were filtering out irrelevant nodes manually. Instead, a much better approach is to have the informer filter the node at the API server level to reduce load on the API server. This is mostly a problem for clusters with 1200+ nodes.

- How to verify it

The MCD should continue to work as-is.

- Description for the changelog
MCD node listers should only be scoped to the node they're running on

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cheesesashimi]

/jira refresh

[openshift-ci-robot]

@cheesesashimi: This pull request references Jira Issue OCPBUGS-55439, which is invalid:

• expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cheesesashimi]

/jira refresh

[openshift-ci-robot]

@cheesesashimi: This pull request references Jira Issue OCPBUGS-55439, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cheesesashimi]

/test e2e-gcp-op-ocl

[isabella-janssen]

lgtm, but I will leave final tagging to a teammate with better context.

[djoshy]

/lgtm

Excited to see the node API counts go down! 😄

Not sure this needs QE, our current suites should cover this. Feel free to unhold when ready to merge.
/hold

[djoshy]

/lgtm
/approve

hello, bot?
/honk

[openshift-ci]

@djoshy:

In response to this:

/lgtm
/approve

hello, bot?
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, djoshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cheesesashimi,djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[djoshy]

/unhold

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 44efb15 and 2 for PR HEAD 244549f in total

[openshift-ci]

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change	244549f	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-aws-ovn-upgrade-out-of-change	244549f	link	false	/test e2e-aws-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-ocl	244549f	link	false	/test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@cheesesashimi: Jira Issue OCPBUGS-55439: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#5015

Jira Issue OCPBUGS-55439 has been moved to the MODIFIED state.

In response to this:

- What I did

Each node in the cluster was also listing all of the other nodes within the cluster and we were filtering out irrelevant nodes manually. Instead, a much better approach is to have the informer filter the node at the API server level to reduce load on the API server. This is mostly a problem for clusters with 1200+ nodes.

- How to verify it

The MCD should continue to work as-is.

- Description for the changelog
MCD node listers should only be scoped to the node they're running on

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cheesesashimi]

/cherry-pick release-4.19

[openshift-cherrypick-robot]

@cheesesashimi: new pull request created: #5057

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cheesesashimi]

/cherry-pick release-4.19 release-4.18 release-4.17 release-4.16

[openshift-cherrypick-robot]

@cheesesashimi: new pull request could not be created: failed to create pull request against openshift/machine-config-operator#release-4.19 from head openshift-cherrypick-robot:cherry-pick-5015-to-release-4.19: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-5015-to-release-4.19."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-4.19 release-4.18 release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cheesesashimi]

/cherry-pick release-4.19 release-4.18 release-4.17 release-4.16

[openshift-cherrypick-robot]

@cheesesashimi: new pull request created: #5058

In response to this:

/cherry-pick release-4.19 release-4.18 release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.