Skip to content

WIP: Start setting control-plane taint #4984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Start setting control-plane taint #4984

wants to merge 1 commit into from

Conversation

stephenfin
Copy link
Contributor

- What I did

The node-role.kubernetes.io/master annotation is deprecated in favour of node-role.kubernetes.io/control-plane [1] and currently produces a warning when modifying resources via oc/kubectl. kubeadm switched to the new label many releases ago [2].

Continue the process of migrating OpenShift by labeling nodes with the new label. Future changes can remove the old label and rename various methods and tests once this has bedded in.

This is a WIP/RFC PR because we need to update all operators to tolerate this label first. I suspect an enhancement is needed to ensure this happens.

- How to verify it

TODO.

- Description for the changelog

@stephenfin
node controller: Start setting control-plane taint
246b689 
The `node-role.kubernetes.io/master` annotation is deprecated in favour
of `node-role.kubernetes.io/control-plane` [1] and currently produces a
warning when modifying resources via `oc`/`kubectl`. kubeadm switched to
the new label many releases ago [2].

Continue the process of migrating OpenShift by labeling nodes with the
new label. Future changes can remove the old label and rename various
methods and tests once this has bedded in.

[1]: https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io-master-taint
[2]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/2067-rename-master-label-taint

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephenfin
Once this PR has been reviewed and has the lgtm label, please assign dkhater-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 30, 2025

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stephenfin