Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vSphere IPI #1373

Merged
merged 1 commit into from
Jan 25, 2020
Merged

Add vSphere IPI #1373

merged 1 commit into from
Jan 25, 2020

Conversation

jcpowermac
Copy link
Contributor

Uses existing baremetal networking like openstack and ovirt.

  • Added manifests and template for vSphere which identical
    beyond names as ovirt (cp and sed).
  • Updated bindata as required
  • Update pkg/operator/bootstrap for vsphere

Requires: openshift/api#541

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 15, 2020
@jcpowermac jcpowermac mentioned this pull request Jan 16, 2020
Closed
@sdodson
Copy link
Member

sdodson commented Jan 20, 2020

@jcpowermac Is this still WIP for any reason other than needing #1377 ?

@jcpowermac
Copy link
Contributor Author

@jcpowermac Is this still WIP for any reason other than needing #1377 ?

That is the only reason its WIP. Need the change we made to the API.

@patrickdillon
Copy link
Contributor

I have tested this with the base image from openshift/cluster-config-operator#111 and the machine-config-operator becomes available.

@jcpowermac jcpowermac changed the title [wip] Add vSphere IPI Add vSphere IPI Jan 23, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2020
@jcpowermac
Copy link
Contributor Author

Took off WIP
Should be ready once this PR merges:
#1393

@jcpowermac
Copy link
Contributor Author

/test all

@yuqi-zhang
Copy link
Contributor

-- FAIL: TestGenerateMachineConfigs (0.44s)
render_test.go:286: failed to generate machine configs: failed to create MachineConfig for role master: failed to execute template: template: ../../../templates/common/vsphere/files/vsphere-coredns-db.yaml:14:26: executing "../../../templates/common/vsphere/files/vsphere-coredns-db.yaml" at <.Infra.Status.PlatformStatus.VSphere.APIServerInternalIP>: can't evaluate field Status in type *v1.Infrastructure

@jcpowermac
Add vSphere IPI
632569c 
Uses existing baremetal networking like openstack and ovirt.

- Added manifests and template for vSphere which identical
beyond names as ovirt (cp and sed).
- Updated bindata as required
- Update pkg/operator/bootstrap for vsphere
@jcpowermac
Copy link
Contributor Author

Updated:
pkg/controller/template/test_data/controller_config_vsphere.yaml

@ashcrow ashcrow requested review from kikisdeliveryservice and ericavonb and removed request for ashcrow January 24, 2020 15:05
@runcom
Copy link
Member

runcom commented Jan 24, 2020

/skip
/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 25, 2020 •
edited
Loading

@jcpowermac: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 632569c link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7d68bf4 into openshift:master Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runcom runcom Awaiting requested review from runcom

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@ericavonb ericavonb Awaiting requested review from ericavonb

Assignees

@runcom runcom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jcpowermac @sdodson @patrickdillon @yuqi-zhang @runcom @openshift-ci-robot @openshift-bot @openshift-merge-robot