Skip to content

Go modules #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2019
Merged

Go modules #399

merged 3 commits into from
Sep 30, 2019

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Sep 19, 2019

Drop dep in favour of go modules

go mod init
go mod tidy
go mod vendor

Use replace for forks, prometheus.client and code-generator.
Enforce GO111MODULE=on and GOFLAGS += -mod=vendor via Make file and DOCKER_CMD

@enxebre
Copy link
Member Author

enxebre commented Sep 19, 2019

/hold
until we open master for 4.3

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 19, 2019
@enxebre
Copy link
Member Author

enxebre commented Sep 30, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2019
@enxebre
Copy link
Member Author

enxebre commented Sep 30, 2019

/test e2e-aws-upgrade

@enxebre
Copy link
Member Author

enxebre commented Sep 30, 2019

/test e2e-azure-operator

@enxebre enxebre mentioned this pull request Sep 30, 2019
Closed
bison
bison approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

But I think we could drop the script we're copying around and then not having the go install ... bits. We can do that another time though.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2019
@bison
Copy link
Contributor

bison commented Sep 30, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit e12fc31 into openshift:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison bison approved these changes

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

@vikaschoudhary16 vikaschoudhary16 Awaiting requested review from vikaschoudhary16

Assignees

@bison bison

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enxebre @bison @openshift-ci-robot @openshift-merge-robot