Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPEDGE-1080: fix: approvers and reviewers update #623

Merged
merged 3 commits into from
May 3, 2024

Conversation

jeff-roche
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 3, 2024

@jeff-roche: This pull request references OCPEDGE-1080 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jeff-roche
Copy link
Contributor Author

/assign @jakobmoellerdev @suleymanakbas91

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 3, 2024
Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels May 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.65%. Comparing base (7ea9e75) to head (a03b4d6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   77.75%   77.65%   -0.11%     
==========================================
  Files          27       27              
  Lines        1960     1960              
==========================================
- Hits         1524     1522       -2     
- Misses        319      320       +1     
- Partials      117      118       +1     

see 1 file with indirect coverage changes

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 3, 2024
@jeff-roche
Copy link
Contributor Author

/retest

@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@jeff-roche
Copy link
Contributor Author

@suleymanakbas91 can we override those failing tests?

@suleymanakbas91
Copy link
Contributor

/lgtm
/override ci/prow/ci-index-lvm-operator-bundle
/override ci/prow/images
/override ci/prow/lvm-operator-e2e-aws
/override ci/prow/lvm-operator-e2e-aws-sno

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
Copy link
Contributor

openshift-ci bot commented May 3, 2024

@suleymanakbas91: Overrode contexts on behalf of suleymanakbas91: ci/prow/ci-index-lvm-operator-bundle, ci/prow/images, ci/prow/lvm-operator-e2e-aws, ci/prow/lvm-operator-e2e-aws-sno

In response to this:

/lgtm
/override ci/prow/ci-index-lvm-operator-bundle
/override ci/prow/images
/override ci/prow/lvm-operator-e2e-aws
/override ci/prow/lvm-operator-e2e-aws-sno

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented May 3, 2024

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ac0d2b4 into openshift:main May 3, 2024
9 checks passed
@jeff-roche jeff-roche deleted the ee-owners branch May 3, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants