Skip to content

OCPEDGE-1921: feat(test): update e2e aws client creation #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

qJkee
Copy link
Contributor

@qJkee qJkee commented Jun 20, 2025

read aws credentials from disk instead of creating a secret with them via additional ci step

read aws credentials from disk instead of creating a secret
with them via additional ci step
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 20, 2025

@qJkee: This pull request references OCPEDGE-1921 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

read aws credentials from disk instead of creating a secret with them via additional ci step

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2025
Copy link
Contributor

openshift-ci bot commented Jun 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.64%. Comparing base (11312cd) to head (8003f37).
Report is 43 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
+ Coverage   68.52%   68.64%   +0.11%     
==========================================
  Files          50       50              
  Lines        3492     3502      +10     
==========================================
+ Hits         2393     2404      +11     
+ Misses        908      907       -1     
  Partials      191      191              

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qJkee
Copy link
Contributor Author

qJkee commented Jun 23, 2025

/override e2e-aws-hypershift

Copy link
Contributor

openshift-ci bot commented Jun 23, 2025

@qJkee: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-aws-hypershift

Only the following failed contexts/checkruns were expected:

  • Red Hat Konflux / lvm-operator-on-pull-request
  • ci/prow/ci-index-lvm-operator-bundle
  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-hypershift
  • ci/prow/e2e-aws-single-node
  • ci/prow/images
  • ci/prow/precommit-check
  • ci/prow/snyk-code
  • ci/prow/snyk-deps
  • ci/prow/unit-test
  • pull-ci-openshift-lvm-operator-main-ci-index-lvm-operator-bundle
  • pull-ci-openshift-lvm-operator-main-e2e-aws
  • pull-ci-openshift-lvm-operator-main-e2e-aws-hypershift
  • pull-ci-openshift-lvm-operator-main-e2e-aws-single-node
  • pull-ci-openshift-lvm-operator-main-images
  • pull-ci-openshift-lvm-operator-main-precommit-check
  • pull-ci-openshift-lvm-operator-main-snyk-code
  • pull-ci-openshift-lvm-operator-main-snyk-deps
  • pull-ci-openshift-lvm-operator-main-unit-test
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-aws-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qJkee
Copy link
Contributor Author

qJkee commented Jun 23, 2025

/override ci/prow/e2e-aws-hypershift

Copy link
Contributor

openshift-ci bot commented Jun 23, 2025

@qJkee: Overrode contexts on behalf of qJkee: ci/prow/e2e-aws-hypershift

In response to this:

/override ci/prow/e2e-aws-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jun 23, 2025

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eggfoobar
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit d82bb45 into openshift:main Jun 23, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants