-
Notifications
You must be signed in to change notification settings - Fork 42
OCPEDGE-1923: feat(config): allow custom namespace installation #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@qJkee: This pull request references OCPEDGE-1923 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qJkee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
+ Coverage 68.52% 69.24% +0.71%
==========================================
Files 50 50
Lines 3492 3502 +10
==========================================
+ Hits 2393 2425 +32
+ Misses 908 890 -18
+ Partials 191 187 -4 🚀 New features to boost your workflow:
|
Fix kustomize manifests in order to correctly handle custom namespace installation and correctly passing it to the manifests
@qJkee: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fix kustomize manifests in order to correctly handle custom namespace installation and correctly passing it to the manifests