Skip to content

OCPBUGS-60033: Prefer nvme-eui symlinks over nvme- #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

OCPBUGS-60033: Prefer nvme-eui symlinks over nvme- #542

merged 1 commit into from
Aug 15, 2025

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Aug 13, 2025 •
edited
Loading

On vSphere, symlink /dev/disk/by-id/nvme-VMware_Virtual_NVMe_Disk_VMware_NVME_0000 is not stable. It get reordered when a disk is added/removed to/from a VM + the VM is rebooted.

Prefer using /dev/disk/by-id/nvme-eui.XYZ if it's available.

@jsafrane
Prefer nvme-eui symlinks over nvme-
76fe618 
On vSphere, symlinks
/dev/disk/by-id/nvme-VMware_Virtual_NVMe_Disk_VMware_NVME-*
are not stable. They get reordered when a disk is added/removed to/from a
VM.

Prefer using /dev/disk/by-id/nvme-eui.XYZ if it's available.
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 13, 2025
@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Jira Issue OCPBUGS-60033, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

On vSphere, symlink
`/dev/disk/by-id/nvme-VMware_Virtual_NVMe_Disk_VMware_NVME_0000 is not stable. It get reordered when a disk is added/removed to/from a VM + the VM is rebooted.

Prefer using /dev/disk/by-id/nvme-eui.XYZ if it's available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Jira Issue OCPBUGS-60033, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

On vSphere, symlink
/dev/disk/by-id/nvme-VMware_Virtual_NVMe_Disk_VMware_NVME_0000 is not stable. It get reordered when a disk is added/removed to/from a VM + the VM is rebooted.

Prefer using /dev/disk/by-id/nvme-eui.XYZ if it's available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dobsonj and tsmetana August 13, 2025 15:45
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2025
@jsafrane
Copy link
Contributor Author

cc @openshift/storage

@dobsonj
Copy link
Member

dobsonj commented Aug 14, 2025

/retest

@dobsonj
Copy link
Member

dobsonj commented Aug 14, 2025

Looks good, waiting on CI.
@jsafrane If you're backporting this, make sure #514 is in the target release branch to avoid creating a duplicate symlink when one already exists on upgraded clusters. It's already in 4.17 and newer.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member

dobsonj commented Aug 15, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 90695a9 into openshift:main Aug 15, 2025
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@jsafrane: Jira Issue OCPBUGS-60033: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-60033 has been moved to the MODIFIED state.

In response to this:

On vSphere, symlink /dev/disk/by-id/nvme-VMware_Virtual_NVMe_Disk_VMware_NVME_0000 is not stable. It get reordered when a disk is added/removed to/from a VM + the VM is rebooted.

Prefer using /dev/disk/by-id/nvme-eui.XYZ if it's available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Contributor Author

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

@jsafrane: new pull request created: #544

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 15, 2025
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: local-storage-diskmaker
This PR has been included in build local-storage-diskmaker-container-v4.20.0-202508151617.p0.g90695a9.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: local-storage-mustgather
This PR has been included in build ose-local-storage-mustgather-container-v4.20.0-202508151617.p0.g90695a9.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: local-storage-operator
This PR has been included in build local-storage-operator-container-v4.20.0-202508151617.p0.g90695a9.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@dobsonj dobsonj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsafrane @openshift-ci-robot @dobsonj @openshift-cherrypick-robot @openshift-bot