Skip to content

Add delete support for ValidatingAdmissionPolicies and ValidatingAdmissionPolicyBindings #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tiraboschi
Copy link
Contributor

Add delete support for ValidatingAdmissionPolicies and ValidatingAdmissionPolicyBindings

@openshift-ci openshift-ci bot requested review from hexfusion and jsafrane April 3, 2025 14:42
Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tiraboschi
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo
Copy link
Member

damdo commented May 27, 2025

Hey Simone 👋 thanks for the PR, you may want to add calls for these also to DeleteAll?

https://github.com/tiraboschi/library-go/blob/cee2a6285beebcdb1c2018744bc0a13f88fc59b5/pkg/operator/resource/resourceapply/generic.go#L352-L357

@tiraboschi
Copy link
Contributor Author

Hey Simone 👋 thanks for the PR, you may want to add calls for these also to DeleteAll?

Done, thanks for the pointer.

expectedEvents []string
}{
{
name: "Should delete webhook if it exists",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ValidatingAdmissionPolicies are not webhooks (compare with ValidatingWebhookConfiguration). This applies to this whole file - existingHooks below, updatedHook, other test names. I would personally use term policy as a shortcut.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

…ssionPolicyBindings

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jun 3, 2025

@tiraboschi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants