-
Notifications
You must be signed in to change notification settings - Fork 120
OCPBUGS-59756: Fix IntOrString cost estimation when schema has a MaxLength constraint #2375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
OCPBUGS-59756: Fix IntOrString cost estimation when schema has a MaxLength constraint #2375
Conversation
@JoelSpeed: This pull request references Jira Issue OCPBUGS-59756, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@JoelSpeed: the contents of this pull request could be automatically validated. The following commits are valid:
Comment |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@JoelSpeed: This pull request references Jira Issue OCPBUGS-59756, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR fixes an issue where the estimated CEL runtime cost of IntOrString types in Kubernetes are miscalculated, due to the ignorance of the openapi schema max length property for the string