-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.17] OCPBUGS-38686: UPSTREAM: 126641: e2e/storage: update block device test to always specify a valid path #2056
base: release-4.17
Are you sure you want to change the base?
Conversation
…cify a valid path in the isEphemeral case, the pvcBlock doesn't have a filled in name, which means the DevicePath is "/mnt". When using the OCI runtime runc, this is valid because runc sanitizes the path, mounting it in `/mnt` in the container. However, the OCI runtime crun does not do this. One can argue the validity of passing a path structured like a directory as a block device, but ultimately from what I can see this wasn't intentional. As such, fix it by setting the mount to be based on the first Volume name, which both cases should have filled out. Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-cherrypick-robot: the contents of this pull request could be automatically validated. The following commits are valid:
Comment |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@openshift-cherrypick-robot: Jira Issue OCPBUGS-38336 has been cloned as Jira Issue OCPBUGS-38686. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-38686, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
1 similar comment
/retest |
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #2054
/assign haircommander