Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-46596: aws/permissions - defaults ec2:DescribeInstanceTypeOfferings #9341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-46596: aws/permissions - defaults ec2:DescribeInstanceTypeOfferings #9341

wants to merge 1 commit into from
+1 −2

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Jan 2, 2025

https://issues.redhat.com/browse/OCPBUGS-46596

Added AWS permission ec2:DescribeInstanceTypeOfferings to the default list to create cluster / PermissionCreateBase group.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 2, 2025
@openshift-ci-robot
Copy link
Contributor

@mtulio: This pull request references Jira Issue OCPBUGS-46596, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-46596

Added AWS permission ec2:DescribeInstanceTypeOfferings to the default list to create cluster / PermissionCreateBase group.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 2, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mtulio. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio
Copy link
Contributor Author

mtulio commented Jan 2, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 2, 2025
@openshift-ci-robot
Copy link
Contributor

@mtulio: This pull request references Jira Issue OCPBUGS-46596, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (yunjiang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
OCPBUGS-46596: aws/perm - default ec2:DescribeInstanceTypeOfferings
821b07b 
ec2:DescribeInstanceTypeOfferings is used by machine pools to discover
supported instance type in the region and zones, when it isn't set in
the pool (control plane, compute, or edge).

The discover falls back to the m6i which is supported in mostly regions,
althrough some regions (e.g. ap-southeast-4 and eu-south-2) will fail as
that tye isn't supported. To the discover mechanism works properly
globally the permission must be added by default.

This permission is missing since minimum permissions has been
introduced, currently only the edge pool is including this permission.
This change moves that requirement to default create group.
@mtulio
Copy link
Contributor Author

mtulio commented Jan 2, 2025

/test e2e-aws-ovn

@mtulio mtulio marked this pull request as ready for review January 2, 2025 06:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Jan 2, 2025

/assign @r4f4 @patrickdillon

r4f4
r4f4 reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 821b07b link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-edge-zones 821b07b link false /test e2e-aws-ovn-edge-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor Author

mtulio commented Jan 9, 2025

Hi @patrickdillon , can I have review here? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

Assignees

@r4f4 r4f4

@patrickdillon patrickdillon

Labels
jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtulio @openshift-ci-robot @r4f4 @patrickdillon