WIP: refactor gcp destroy #9206
Conversation
An initial commit for larger refactoring GCP destroy code, this encapsulates the boiler plate destroy flow for many resources into a reusable function. This commit just contains the resources which use the exact same flow. Several more resources have very slight variations, either because they have been updated over time or they have been considered a special snowflake. These should be easily adapted in a subsequent commit but this commit keeps things simple for the resources that require only minimal changes. Encapsulating the boiler plate logic not only makes the code easier to read, but makes the code more maintainble by imposing structure: it reduces the surface area for where resource-specific changes can be introduced.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
An initial commit for larger refactoring GCP
destroy code, this encapsulates the boiler
plate destroy flow for many resources into
a reusable function.
This commit just contains the resources which
use the exact same flow. Several more resources
have very slight variations, either because
they have been updated over time or they
have been considered a special snowflake. These
should be easily adapted in a subsequent commit
but this commit keeps things simple for the
resources that require only minimal changes.
Encapsulating the boiler plate logic not only
makes the code easier to read, but makes the
code more maintainble by imposing structure:
it reduces the surface area for where
resource-specific changes can be introduced.