OCPBUGS-44193: move GCP zone filtering client-side

[patrickdillon]

This commit removes GCP server-side filtering when listing zones. GCP imposes a "filtered list cost overhead quota" which limits the amount of server-side filtering we can utilize. More information can be found here:

https://cloud.google.com/compute/api-quota

We have seen CI jobs failing due to:

level=fatal msg=failed to fetch Cluster API Machine Manifests: failed to generate asset "Cluster API Machine Manifests": failed to fetch availability zones: failed to get zones for project: failed to get zones from project XXXXXXXXXXXXXXXXXXXXXXXX: googleapi: Error 403: Quota exceeded for quota metric 'Filtered list cost overhead' and limit 'Filtered list cost overhead per minute' of service 'compute.googleapis.com' for consumer 'project_number:711936183532'.

GCP recommends utilizing client-side filters to resolve this: https://cloud.google.com/compute/docs/api/best-practices#client-side-filter

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-44193, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit removes GCP server-side filtering when listing zones. GCP imposes a "filtered list cost overhead quota" which limits the amount of server-side filtering we can utilize. More information can be found here:

https://cloud.google.com/compute/api-quota

We have seen CI jobs failing due to:

level=fatal msg=failed to fetch Cluster API Machine Manifests: failed to generate asset "Cluster API Machine Manifests": failed to fetch availability zones: failed to get zones for project: failed to get zones from project XXXXXXXXXXXXXXXXXXXXXXXX: googleapi: Error 403: Quota exceeded for quota metric 'Filtered list cost overhead' and limit 'Filtered list cost overhead per minute' of service 'compute.googleapis.com' for consumer 'project_number:711936183532'.

GCP recommends utilizing client-side filters to resolve this: https://cloud.google.com/compute/docs/api/best-practices#client-side-filter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[patrickdillon]

/cc @r4f4 @barbacbd

[patrickdillon]

/jira refresh

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-44193, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from patrickdillon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/asset/installconfig/gcp/OWNERS
• pkg/asset/machines/gcp/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[r4f4]

/lgtm