OCPBUGS-30292: If agent proxy defined add RendezvousIP to noProxy #9153
Conversation
openshift-ci-robot
added
jira/severity-low
|
@bfournie: This pull request references Jira Issue OCPBUGS-30292, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @rwsu @zaneb @andfasano |
openshift-ci
bot
requested review from
andfasano,
rwsu,
zaneb and
pawanpinjarkar
If proxy is defined in install-config, add the RendezvousIP to the noproxy field in the generated manifests to ensure the Rendezvous host can be accessed. This is an additional fix beyond openshift#9083 as it was found that when just setting the IP in 10-default-env.conf it did not get passed to the assisted-installer when it was started.
bfournie
force-pushed
the
agent-rendezvous-noproxy
branch
from
6962e53
to
b5b2cae
Compare
|
/lgtm |
|
/test e2e-agent-ha-dualstack |
|
@bfournie: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Does this mean that we had a bigger problem, that the user's proxy settings were never passed on to the cluster?? |
No, the proxy settings were passed fine to the cluster and to the assisted-installer. Its just that updating the noProxy directly in 10_default.conf.env did not forward the updated noproxy to the assisted installer container. |
| agentClusterInstall.Spec.Proxy = (*hiveext.Proxy)(getProxy(installConfig.Config.Proxy)) | ||
| rendezvousIP := "" | ||
| if agentConfig.Config != nil { | ||
| rendezvousIP = agentConfig.Config.RendezvousIP |
There was a problem hiding this comment.
Since this will end up in the cluster config, there's something to be said for adding the whole Machine CIDR (which assisted will add again anyway), so that no single node is configured differently to the others.
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
If proxy is defined in install-config, add the RendezvousIP to the noproxy field in the generated manifests to ensure the Rendezvous host can be accessed.
This is an additional fix beyond #9083 as it was found that when just setting the IP in 10-default-env.conf it did not get passed to the assisted-installer when it was started.