Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3493: Remove ARO build flag from installer #9124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rna-afk
Copy link
Contributor

@rna-afk rna-afk commented Oct 22, 2024

Removing the ARO build flag from the installer to achieve the goal of moving ARO installs closer to the installer. Ideally, these ARO specific changes to the installs/installer need to be done either in the wrapper or hive.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 22, 2024

@rna-afk: This pull request references CORS-3493 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Removing the ARO build flag from the installer to achieve the goal of moving ARO installs closer to the installer. Ideally, these ARO specific changes to the installs/installer need to be done either in the wrapper or hive.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 22, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rna-afk. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rna-afk rna-afk force-pushed the remove_aro_build_flag branch 2 times, most recently from 67fb5b2 to 808e68c Compare October 23, 2024 20:56
Removing the ARO build flag from the installer to achieve the goal
of moving ARO installs closer to the installer. Ideally, these
ARO specific changes to the installs/installer need to be done
either in the wrapper or hive.
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

@rna-afk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-shared-vpc aba5982 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azure-ovn aba5982 link true /test e2e-azure-ovn
ci/prow/e2e-azurestack aba5982 link false /test e2e-azurestack
ci/prow/images aba5982 link true /test images
ci/prow/azure-ovn-marketplace-images aba5982 link false /test azure-ovn-marketplace-images
ci/prow/e2e-aws-ovn aba5982 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rna-afk rna-afk changed the title WIP: CORS-3493: Remove ARO build flag from installer CORS-3493: Remove ARO build flag from installer Nov 4, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants