Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] OCPBUGS-42554: only allow a single network in failure domain topology #9060

Open
wants to merge 1 commit into
base: release-4.15
Choose a base branch
from
Open

[release-4.15] OCPBUGS-42554: only allow a single network in failure domain topology #9060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
OCPBUGS-38551: only allow a single network in failure domain topology
  • Loading branch information
@rvanderp3
rvanderp3 authored and openshift-cherrypick-robot committed Sep 27, 2024
commit e4129e72d0cb277294e157f6ab8854a7e7d58dbc
4 changes: 4 additions & 0 deletions pkg/types/vsphere/validation/platform.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,10 @@ func validateFailureDomains(p *vsphere.Platform, fldPath *field.Path, isLegacyUp
}
}

if len(failureDomain.Topology.Networks) > 1 {
allErrs = append(allErrs, field.Required(topologyFld.Child("networks"), "must specify a single network"))
}

// Folder in failuredomain is optional
if len(failureDomain.Topology.Folder) != 0 {
folderPathRegexp := regexp.MustCompile(`^/(.*?)/vm/(.*?)$`)
Expand Down