Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSASINFRA-3695: openstack: Create security group rules in batches #9042

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OSASINFRA-3695: openstack: Create security group rules in batches #9042

wants to merge 2 commits into from
+243 −336

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Sep 19, 2024 •
edited
Loading

Create security group rules in batches to reduce the number of calls to the OpenStack API. This is a performance improvement that is not expected to result in any functional change.

This change requires a dependency bump of Gophercloud to v2.4.0.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 19, 2024
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request explicitly references no jira issue.

In response to this:

Exercise dependency hygiene.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bfournie and rna-afk September 19, 2024 09:38
@pierreprinetti
Copy link
Member Author

/retest-required

@pierreprinetti
Copy link
Member Author

/cc mandre

@openshift-ci openshift-ci bot requested a review from mandre September 19, 2024 13:55
@pierreprinetti
Copy link
Member Author

/hold
This is for 4.18

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2024
@pierreprinetti
Copy link
Member Author

/hold cancel

Revamped for 4.19

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@pierreprinetti pierreprinetti changed the title NO-JIRA: Deps: Update Gophercloud OSASINFRA-3695: openstack: Create security group rules in batches Dec 20, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2024 •
edited by openshift-ci bot
Loading

@pierreprinetti: This pull request references OSASINFRA-3695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This dependency bump enables batch security group rule creation in OpenStack.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2024 •
edited by openshift-ci bot
Loading

@pierreprinetti: This pull request references OSASINFRA-3695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Create security group rules in batches to reduce the number of calls to the OpenStack API. This is a performance improvement that is not expected to result in any functional change.

This change requires a dependency bump of Gophercloud to v2.4.0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mandre
mandre reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The code looks good to me, let's see if the CI agrees.

@mandre
Copy link
Member

mandre commented Dec 20, 2024

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@pierreprinetti
Copy link
Member Author

@sadasu this requires an approval for the dependency bump 🙏

@pierreprinetti
deps: Bump Gophercloud to v2.4.0
757a97f 
This dependency bump enables batch security group rule creation in
OpenStack.
@pierreprinetti
openstack: Bulk create security group rules
af0d1eb
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
mandre
mandre reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@pierreprinetti
Copy link
Member Author

/retest-required

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upi c912101 link true /test e2e-azure-ovn-upi
ci/prow/e2e-gcp-ovn-upi c912101 link true /test e2e-gcp-ovn-upi
ci/prow/e2e-gcp-ovn c912101 link true /test e2e-gcp-ovn
ci/prow/e2e-agent-compact-ipv4 c912101 link true /test e2e-agent-compact-ipv4
ci/prow/e2e-azure-ovn c912101 link true /test e2e-azure-ovn
ci/prow/e2e-aws-ovn-edge-zones-manifest-validation c912101 link true /test e2e-aws-ovn-edge-zones-manifest-validation
ci/prow/terraform-verify-vendor c912101 link true /test terraform-verify-vendor
ci/prow/integration-tests c912101 link true /test integration-tests
ci/prow/e2e-vsphere-ovn-upi c912101 link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-vsphere-ovn c912101 link true /test e2e-vsphere-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 c912101 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-azure-ovn-resourcegroup af0d1eb link false /test e2e-azure-ovn-resourcegroup
ci/prow/e2e-openstack-ovn af0d1eb link true /test e2e-openstack-ovn
ci/prow/e2e-openstack-proxy af0d1eb link false /test e2e-openstack-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@bfournie bfournie Awaiting requested review from bfournie

@rna-afk rna-afk Awaiting requested review from rna-afk

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pierreprinetti @openshift-ci-robot @mandre @patrickdillon @openshift-merge-robot