-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Allow setting of ManagedBy field #8119
base: main
Are you sure you want to change the base?
Conversation
Adding ManagedBy field in the install config to let users set the ManagedBy field in the resource group the installer creates.
Creating a resource group in PreProvision stage of CAPZ to enable users to set the ManagedBy field.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
// ManagedBy sets the managedBy field in the azure resource group. | ||
ManagedBy string `json:"managedBy,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we've discussed this before, but if this is a new field we're adding specifically for ARO, we might want to consider this a bit more. I don't know if we have an overall strategy for how we are going to deal with ARO configuration of the installer when those configs don't fit general use cases. We should consider that before starting to add fields one at a time (it is a valid option, but we should consider it over adding, say, an ARO flag).
If ARO has the ability to edit installer manifests, we could expose this configuration directly in the cluster API and that would be a great way of handling this.
cc @jhixson74
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Adding a provision for the users to set the ManagedBy field in the resourceGroup
during azure CAPI installation. Also adding a step to create the resource group
since CAPI does not have the option to set the ManagedBy field if it creates the
resource group.