Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1387: enable additional tags to be associated with vsphere machines #7905

Merged
merged 2 commits into from
Feb 4, 2024
Merged

SPLAT-1387: enable additional tags to be associated with vsphere machines #7905

merged 2 commits into from
Feb 4, 2024

Conversation

rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Jan 12, 2024 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 12, 2024 •
edited by openshift-ci bot
Loading

@rvanderp3: This pull request references SPLAT-1387 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

depends on openshift/api#1697

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot
Loading

@rvanderp3: This pull request references SPLAT-1387 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

depends on :

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot
Loading

@rvanderp3: This pull request references SPLAT-1387 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

depends on :

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rvanderp3 rvanderp3 marked this pull request as ready for review January 17, 2024 21:42
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2024
@rvanderp3
Copy link
Contributor Author

/hold

placing a hold until tests are in good shape

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024
@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 31, 2024 •
edited by openshift-ci bot
Loading

@rvanderp3: This pull request references SPLAT-1387 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

depends on :

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
@rvanderp3
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2024
@rvanderp3 rvanderp3 force-pushed the SPLAT-1387 branch 3 times, most recently from c348370 to 079d853 Compare January 31, 2024 19:24
@rvanderp3
Copy link
Contributor Author

/test e2e-vsphere-ovn
/test e2e-vsphere-zones-techpreview

@jcpowermac
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
@rvanderp3
Copy link
Contributor Author

/assign @sadasu

@sadasu
Copy link
Contributor

sadasu commented Feb 2, 2024

/approve

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2024
@sadasu
Copy link
Contributor

sadasu commented Feb 2, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 4, 2024

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-aws-ovn-single-node 079d8537a0600f0904071e7452e083fbb6dd8c5c link false /test altinfra-e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn-shared-vpc 079d8537a0600f0904071e7452e083fbb6dd8c5c link false /test e2e-gcp-ovn-shared-vpc
ci/prow/e2e-metal-ipi-ovn-dualstack 079d8537a0600f0904071e7452e083fbb6dd8c5c link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-openstack-proxy 079d8537a0600f0904071e7452e083fbb6dd8c5c link false /test e2e-openstack-proxy
ci/prow/e2e-metal-single-node-live-iso 079d8537a0600f0904071e7452e083fbb6dd8c5c link false /test e2e-metal-single-node-live-iso
ci/prow/altinfra-e2e-aws-ovn-wavelengthzones 079d8537a0600f0904071e7452e083fbb6dd8c5c link false /test altinfra-e2e-aws-ovn-wavelengthzones
ci/prow/e2e-openstack-ovn 079d8537a0600f0904071e7452e083fbb6dd8c5c link true /test e2e-openstack-ovn
ci/prow/e2e-gcp-secureboot 079d8537a0600f0904071e7452e083fbb6dd8c5c link false /test e2e-gcp-secureboot
ci/prow/e2e-ibmcloud-ovn 079d8537a0600f0904071e7452e083fbb6dd8c5c link false /test e2e-ibmcloud-ovn
ci/prow/e2e-vsphere-zones 7d5d26a link false /test e2e-vsphere-zones
ci/prow/e2e-vsphere-zones-techpreview 7d5d26a link false /test e2e-vsphere-zones-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 751e13a into openshift:master Feb 4, 2024
23 of 25 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202402041810.p0.g751e13a.assembly.stream for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

Assignees

@sadasu sadasu

@jcpowermac jcpowermac

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rvanderp3 @openshift-ci-robot @jcpowermac @sadasu @openshift-bot @openshift-merge-robot