builder,dispatcher: Parse ADD --checksum

[jfroy]

Parse the new ADD --checksum flag.

See https://docs.docker.com/build/dockerfile/release-notes/#160.

This will be consumed by buildah. See containers/buildah#5135.

FROM scratch
ADD --checksum=sha256:5df80a9219a28d21f96e8c99e5406d19dbe65b9673a7724e587584b02143038c https://github.com/containers/podman/releases/download/v4.7.2/podman-remote-static-linux_amd64.tar.gz /

[openshift-ci]

Hi @jfroy. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nalind]

Thanks for this!

/ok-to-test

Can you have the dockerclient.ClientExecutor implementation (somewhere around dockerclient/client.go's line 879) complain when its methods are passed new fields which it doesn't know what to do with, sort of like the Run() method complains about flags that it doesn't implement? If we don't remember to do that, it'll just start quietly ignoring flags that it used to produce errors over before, and users of the imagebuilder CLI might come to think that those options actually work. That is an oversight that has come back to bite us before.

[jfroy]

Thanks for this!

/ok-to-test

Can you have the dockerclient.ClientExecutor implementation (somewhere around dockerclient/client.go's line 879) complain when its methods are passed new fields which it doesn't know what to do with, sort of like the Run() method complains about flags that it doesn't implement? If we don't remember to do that, it'll just start quietly ignoring flags that it used to produce errors over before, and users of the imagebuilder CLI might come to think that those options actually work. That is an oversight that has come back to bite us before.

Yeah I was worried about imagebuilder itself now silently ignoring the flag. I don't quite have the time to actually implement the flag in this project, but at least rejecting it is necessary. In particular, it will give a dangerous false sense of security if it is silently ignored.

[nalind]

/approve

[TomSweeneyRedHat]

LGTM
and happy greeen test buttons

[rhatdan]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jfroy, nalind, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nalind,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jfroy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.