OCPBUGS-61175: Let cluster-storage-operator to grant NetworkPolicies#6930
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mpatlasov
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@mpatlasov: This pull request references Jira Issue OCPBUGS-61175, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
area/control-plane-operator
|
/test all |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mpatlasov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Test Resultse2e-aks
Failed TestsTotal failed tests: 16
... and 11 more failed tests e2e-aws
Failed TestsTotal failed tests: 22
... and 17 more failed tests |
|
/retest-required |
mpatlasov
force-pushed
the
OCPBUGS-61175-NetworkPolicies-RBAC-for-cso-in-hostedcontrolplane
branch
from
691b297 to
a9a15ba
Compare
|
/test all |
…cies Manila csi driver controller pods reside in a custome namespace (`openshift-manila-csi-driver`). Hence, Manila csi driver operator must create NetworkPolicy for them expicitly. It is cluster-storage-operator who is legit to grant permissions for that to Manila csi driver operator. But to do it, cluster-storage-operator itself must have proper permissions.
mpatlasov
force-pushed
the
OCPBUGS-61175-NetworkPolicies-RBAC-for-cso-in-hostedcontrolplane
branch
from
a9a15ba to
122485a
Compare
|
/test all |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@mpatlasov: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
What this PR does / why we need it:
Manila csi driver controller pods reside in a custome namespace (
openshift-manila-csi-driver). Hence, Manila csi driver operator must create NetworkPolicy for them expicitly. It is cluster-storage-operator who is legit to grant permissions for that to Manila csi driver operator. But to do it, cluster-storage-operator itself must have proper permissions.