Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-1685: bump openshift/api #4095

Merged
merged 4 commits into from
May 28, 2024

Conversation

muraee
Copy link
Contributor

@muraee muraee commented May 27, 2024

What this PR does / why we need it:
fixes ValidatingAdmissionPolicy feature gate not enabled
Enabled in openshift/api#1888
Needs openshift/release#52491

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 27, 2024

@muraee: This pull request references TRT-1685 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
fixes ValidatingAdmissionPolicy feature gate not enabled

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@enxebre
Copy link
Member

enxebre commented May 27, 2024

Can you link to the counterpart PR where this changed was introduced?
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@muraee
Copy link
Contributor Author

muraee commented May 27, 2024

enabled in openshift/api#1888

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 27, 2024

@muraee: This pull request references TRT-1685 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
fixes ValidatingAdmissionPolicy feature gate not enabled
enabled in openshift/api#1888

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@muraee muraee force-pushed the fix-feature-gates branch from 13419e2 to 4e58f6d Compare May 27, 2024 14:03
@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI and removed lgtm Indicates that a PR is ready to be merged. do-not-merge/needs-area labels May 27, 2024
muraee added 2 commits May 27, 2024 16:25
- fixes ValidatingAdmissionPolicy feature gate not enabled
@muraee muraee force-pushed the fix-feature-gates branch from 4e58f6d to 154657e Compare May 27, 2024 14:27
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label May 27, 2024
@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label May 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 28, 2024

@muraee: This pull request references TRT-1685 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
fixes ValidatingAdmissionPolicy feature gate not enabled
Enabled in openshift/api#1888
Needs openshift/release#52491

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@orenc1
Copy link
Contributor

orenc1 commented May 28, 2024

openshift/release#52491 is merged.
/retest

@muraee
Copy link
Contributor Author

muraee commented May 28, 2024

/retest

@muraee muraee force-pushed the fix-feature-gates branch from c1f5956 to 119b291 Compare May 28, 2024 13:03
@muraee muraee force-pushed the fix-feature-gates branch from 119b291 to 53d4652 Compare May 28, 2024 14:01
@enxebre
Copy link
Member

enxebre commented May 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4c2f51c and 2 for PR HEAD 53d4652 in total

@muraee
Copy link
Contributor Author

muraee commented May 28, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented May 28, 2024

@muraee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kubevirt-azure-ovn 53d4652 link false /test e2e-kubevirt-azure-ovn
ci/prow/e2e-azure 53d4652 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 597b804 into openshift:main May 28, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants