GIE-95: rename and delete functionality for chat history#114
GIE-95: rename and delete functionality for chat history#114grantsydney wants to merge 5 commits intomainfrom
Conversation
|
@grantsydney: This pull request references GIE-95 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantsydney The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…new chat when deleting active chat
|
@grantsydney: This pull request references GIE-95 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@grantsydney: This pull request references GIE-95 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| if (isEventFromInput(e)) return; | ||
| onClick(conversation); | ||
| }} | ||
| onKeyDown={(e) => { |
There was a problem hiding this comment.
The row’s onKeyDown handler triggers navigation on Enter/Space, but it doesn’t guard against key events coming from child controls (like the kebab).
Right now, pressing Enter or Space on the dropdown toggle can both open the menu and navigate into the conversation. Can you make sure keyboard interaction with the menu doesn’t trigger row navigation?
|
@grantsydney: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |


Description
Adds rename and delete for conversations in chat history. Refactors EditableChatHeader so it works in two variants: inline (in the history list) and default (chat header), with optional icon and delete. Introduces a delete hook that calls the backend (
useDeleteConversation) and a reusable modal hook for the delete confirmation flow (useDeleteConversationModal). When the user deletes the active conversation or the last conversation in the list, the app navigates to the new-chat screen; useswindow.location.replacefor that navigation so the new-chat view reliably loads (router navigate was leaving a blank screen when the history list became empty).Type of Change
Related Issues
Fixes #
Changes Made
DeleteConversationModal) and reusable modal hook (useDeleteConversationModal); backend delete hook (useDeleteConversation)EditableChatHeader; i18n for header and modalwindow.location.replaceso the new-chat view always loadsuseUpdateConversationTitlefor renaming; export new hooks from AIStateuseDeleteConversationModalTesting Done
Test Details:
ChatHistory tests updated (useDeleteConversationModal mock); all pass. Manually: rename (open rename, type including Space, save/cancel), delete (open modal, confirm/cancel, error display), row click/Enter/Space when not editing.
Screenshots/Videos
Click to expand
Definition of Done (DOD)
Code Quality
Testing
Documentation
Review & Quality
Pre-Merge
Additional Notes
Reviewer Guidance