Add OKD featureset enhancement #1899
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jatinsu
force-pushed
the
OKD-featuregates
branch
from
9a16308 to
a81a730
Compare
jatinsu
force-pushed
the
OKD-featuregates
branch
2 times, most recently
from
075812e to
a0218a1
Compare
jatinsu
force-pushed
the
OKD-featuregates
branch
from
a0218a1 to
8808148
Compare
| #### Scenario 1: Installing a new OKD cluster | ||
|
|
||
| 1. OKD cluster administrator initiates a cluster installation using `openshift-install` built for OKD | ||
| 2. The installer automatically sets the feature set to "OKD" in the cluster configuration |
| - Resource consumption impact should be minimal as the feature set itself only controls which features are enabled, not the features themselves | ||
| - Individual features enabled by the OKD feature set may have their own resource implications | ||
|
|
||
| **MicroShift:** |
There was a problem hiding this comment.
OKD featureset shouldn't affect microshift right?
| - For the initial implementation, no override is planned | ||
| - Can be added in a future enhancement if a compelling use case emerges | ||
|
|
||
| ## Test Plan |
There was a problem hiding this comment.
Could you verify the Test Plan? We haven't really talked about creating tests. Should I create a JIRA ticket to create tests for the featureset?
| - Feature set remains OKD after upgrade | ||
| - Feature gates are correctly maintained across upgrades | ||
|
|
||
| ## Graduation Criteria |
There was a problem hiding this comment.
Could you verify this as well? To me, graduation criteria is really meant for features, not really the featureset. I was thinking of omitting this section, but I wanted to ask before I did so
| ### Upgrade Strategy | ||
|
|
||
| **OKD Clusters:** | ||
| - Existing OKD clusters without the OKD feature set: During the upgrade to the first version supporting the OKD feature set, the feature set should be automatically enabled if the cluster is detected as OKD. This should be handled by the cluster-version-operator or similar component. |
There was a problem hiding this comment.
I don't believe we've ever tested this. Would current OKD clusters have the featureset automatically applied once they upgrade? Or would the featureset only apply to new clusters?
| ### Downgrade Strategy | ||
|
|
||
| **Downgrading from a version with OKD feature set to a version without:** | ||
| - If an OKD cluster with the OKD feature set is downgraded to a version that does not recognize the OKD feature set: |
There was a problem hiding this comment.
Does OKD/OpenShift support downgrades?
|
|
||
| **Recommendation:** Implement Option 1 (automatic migration) with clear logging and documentation. This provides the smoothest upgrade experience for OKD users. | ||
|
|
||
| ## Version Skew Strategy |
There was a problem hiding this comment.
Could you verify the "Version Skew Strategy" section as well
2 participants
This PR is to create an enhancement for the OKD featureset.
For more context: openshift/api#2451