Skip to content

Network flow matrix: add missing info #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Network flow matrix: add missing info #1798

wants to merge 2 commits into from

Conversation

aabughosh
Copy link

@aabughosh aabughosh commented May 14, 2025 •
edited
Loading

add explanation about the none type platform and how to represnt it

update the oc command information

@openshift-ci openshift-ci bot requested review from danwinship and dougbtv May 14, 2025 17:41
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aabughosh aabughosh force-pushed the nonetypeplatform branch 2 times, most recently from bae80c5 to 68c64d0 Compare May 15, 2025 07:37
@aabughosh
update the oc command information
4654126 
oc command is created by krew plugin
@aabughosh aabughosh changed the title add explanation about the none type platform and how to represent it add missing info May 15, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2025

@aabughosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aabughosh aabughosh changed the title add missing info Network flow matrix: add missing info May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebrandon1 sebrandon1 sebrandon1 approved these changes

@danwinship danwinship Awaiting requested review from danwinship

@dougbtv dougbtv Awaiting requested review from dougbtv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabughosh @sebrandon1