Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLAT-1159: installer: support of extending workers to AWS Wavelength #1510

Closed

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Oct 31, 2023

This enhancement introduces the support of installing a cluster on AWS extending worker nodes to Wavelength - as edge zones.

This is part of the feature OCPSTRAT-736, covering the following epics/goals:

  • Goal 1 (SPLAT-1125): Fully automate the network requirements to deploy edge nodes on AWS Wavelength
  • Goal 2 (SPLAT-1218): Support Installing a cluster in existing VPC (BYO VPC) extending nodes to AWS Wavelength
  • Goal 3 (SPLAT-1219): Document the steps to extend existing OpenShift clusters running on AWS to the edge nodes in AWS Wavelength
  • Goal 4 (SPLAT-1220): Carrier IP Address assignment when creating EC2 instances with Machine API

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 31, 2023

@mtulio: This pull request references OCPSTRAT-736 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.15.0" version, but no target version was set.

In response to this:

This enhancement introduces the support of installing a cluster on AWS extending worker nodes to Wavelength Zones - as edge zones.

This is part of the feature OCPSTRAT-736, covering the following epics/goals:

  • Goal 1 (SPLAT-1125): Fully automate the network requirements to deploy edge nodes on AWS Wavelength Zones
  • Goal 2 (SPLAT-1218): Support Installing a cluster in existing VPC (BYO VPC) extending nodes to AWS Wavelength Zones
  • Goal 3 (SPLAT-1219): Document the steps to extend existing OpenShift clusters running on AWS to the edge nodes in AWS Wavelength Zones

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2023
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jerpeter1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio mtulio force-pushed the installer-aws-wavelength-zones branch 2 times, most recently from bb5c3b4 to dea48c8 Compare November 2, 2023 02:40
@mtulio mtulio force-pushed the installer-aws-wavelength-zones branch from dea48c8 to bdceb31 Compare November 11, 2023 02:45
@mtulio mtulio marked this pull request as ready for review November 11, 2023 02:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2023
@mtulio mtulio force-pushed the installer-aws-wavelength-zones branch from bdceb31 to 7fbd45a Compare November 11, 2023 02:58
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2023

@mtulio: This pull request references OCPSTRAT-736 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.15.0" version, but no target version was set.

In response to this:

This enhancement introduces the support of installing a cluster on AWS extending worker nodes to Wavelength Zones - as edge zones.

This is part of the feature OCPSTRAT-736, covering the following epics/goals:

  • Goal 1 (SPLAT-1125): Fully automate the network requirements to deploy edge nodes on AWS Wavelength Zones
  • Goal 2 (SPLAT-1218): Support Installing a cluster in existing VPC (BYO VPC) extending nodes to AWS Wavelength Zones
  • Goal 3 (SPLAT-1219): Document the steps to extend existing OpenShift clusters running on AWS to the edge nodes in AWS Wavelength Zones
  • Goal 4 (SPLAT-1220): Carrier IP Address assignment when creating EC2 instances with Machine API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio
Copy link
Contributor Author

mtulio commented Nov 11, 2023

Would you mind taking a look at this proposal?
/assign @rvanderp3 @JoelSpeed @patrickdillon

Copy link
Contributor

openshift-ci bot commented Nov 11, 2023

@mtulio: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2023
@mtulio mtulio changed the title OCPSTRAT-736: installer: support AWS Wavelength zones OCPSTRAT-736: installer: support of extending workers to AWS Wavelength Dec 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2023

@mtulio: This pull request references OCPSTRAT-736 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.15" instead.

In response to this:

This enhancement introduces the support of installing a cluster on AWS extending worker nodes to Wavelength - as edge zones.

This is part of the feature OCPSTRAT-736, covering the following epics/goals:

  • Goal 1 (SPLAT-1125): Fully automate the network requirements to deploy edge nodes on AWS Wavelength Zones
  • Goal 2 (SPLAT-1218): Support Installing a cluster in existing VPC (BYO VPC) extending nodes to AWS Wavelength Zones
  • Goal 3 (SPLAT-1219): Document the steps to extend existing OpenShift clusters running on AWS to the edge nodes in AWS Wavelength Zones
  • Goal 4 (SPLAT-1220): Carrier IP Address assignment when creating EC2 instances with Machine API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2023

@mtulio: This pull request references OCPSTRAT-736 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.15" instead.

In response to this:

This enhancement introduces the support of installing a cluster on AWS extending worker nodes to Wavelength - as edge zones.

This is part of the feature OCPSTRAT-736, covering the following epics/goals:

  • Goal 1 (SPLAT-1125): Fully automate the network requirements to deploy edge nodes on AWS Wavelength
  • Goal 2 (SPLAT-1218): Support Installing a cluster in existing VPC (BYO VPC) extending nodes to AWS Wavelength
  • Goal 3 (SPLAT-1219): Document the steps to extend existing OpenShift clusters running on AWS to the edge nodes in AWS Wavelength
  • Goal 4 (SPLAT-1220): Carrier IP Address assignment when creating EC2 instances with Machine API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Rotten proposals close after an additional 7d of inactivity.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 18, 2023
@openshift-bot
Copy link

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

Copy link
Contributor

openshift-ci bot commented Dec 25, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Dec 25, 2023
@dhellmann
Copy link
Contributor

(automated message) This pull request is closed with lifecycle/rotten. The associated Jira ticket, OCPSTRAT-736, has status "In Progress". Should the PR be reopened, updated, and merged? If not, removing the lifecycle/rotten label will tell this bot to ignore it in the future.

@dhellmann
Copy link
Contributor

dhellmann commented Jan 19, 2024

(automated message) This pull request is closed with lifecycle/rotten. The associated Jira ticket, OCPSTRAT-736, has status "In Progress". Should the PR be reopened, updated, and merged? If not, removing the lifecycle/rotten label will tell this bot to ignore it in the future.

@dhellmann
Copy link
Contributor

dhellmann commented Jan 26, 2024

(automated message) This pull request is closed with lifecycle/rotten. The associated Jira ticket, OCPSTRAT-736, has status "Release Pending". Should the PR be reopened, updated, and merged? If not, removing the lifecycle/rotten label will tell this bot to ignore it in the future.

@dhellmann dhellmann removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 26, 2024
@mtulio mtulio changed the title OCPSTRAT-736: installer: support of extending workers to AWS Wavelength SPLAT-1159: installer: support of extending workers to AWS Wavelength Jan 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2025

@mtulio: This pull request references SPLAT-1159 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This enhancement introduces the support of installing a cluster on AWS extending worker nodes to Wavelength - as edge zones.

This is part of the feature OCPSTRAT-736, covering the following epics/goals:

  • Goal 1 (SPLAT-1125): Fully automate the network requirements to deploy edge nodes on AWS Wavelength
  • Goal 2 (SPLAT-1218): Support Installing a cluster in existing VPC (BYO VPC) extending nodes to AWS Wavelength
  • Goal 3 (SPLAT-1219): Document the steps to extend existing OpenShift clusters running on AWS to the edge nodes in AWS Wavelength
  • Goal 4 (SPLAT-1220): Carrier IP Address assignment when creating EC2 instances with Machine API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Contributor Author

mtulio commented Jan 8, 2025

For some reason this EP has been lost when wrapping up the feature last year.

The feature has been added to 4.15+. I am reopening this PR to formalize the flow.

/assign @rvanderp3 @JoelSpeed @patrickdillon

/reopen

Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

@mtulio: Failed to re-open PR: state cannot be changed. The installer-aws-wavelength-zones branch was force-pushed or recreated.

In response to this:

For some reason this EP has been lost when wrapping up the feature last year.

The feature has been added to 4.15+. I am reopening this PR to formalize the flow.

/assign @rvanderp3 @JoelSpeed @patrickdillon

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants