Skip to content

MGMT-19632: Extending the e2e job to validate the kernel-rt versions matches. #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

ybettan
Copy link
Member

@ybettan ybettan commented Jan 6, 2025

We are validating that the DTK image contain the kernel packages matching the running kernel on the node.

This commit is extending the job to also compare DTK's kernel-rt packages and the RT kernel that the node will reboot into if configured to do so.

Copy link

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@ybettan
Copy link
Member Author

ybettan commented Jan 6, 2025

/hold

I want to make sure it fails on a clusterbot cluster with a broken sync between kernel and kernel-rt in it.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2025
We are validating that the DTK image contain the kernel packages matching
the running kernel on the node.

This commit is extending the job to also compare DTK's kernel-rt
packages and the RT kernel that the node will reboot into if configured
to do so.

Signed-off-by: Yoni Bettan <yonibettan@gmail.com>
@ybettan
Copy link
Member Author

ybettan commented Jan 6, 2025

/unhold

The test is failing as expected.

+ echo '## TEST: Checking that kernel-rt version in driver-toolkit matches the node ##'
## TEST: Checking that kernel-rt version in driver-toolkit matches the node ##
+ test_kernel_rt_version
++ oc get clusterversion -o yaml
++ yq '.items[0].status.desired.version'
+ ocp_version=4.17.8
++ oc adm release info quay.io/openshift-release-dev/ocp-release:4.17.8-x86_64 --image-for=rhel-coreos-extensions
+ rhel_coreos_extensions_image=quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:b47aa41d9f732ae42fd4a9f607caecf16478eeb000c5c1f6b8c869b096dcc48b
++ podman run -it --rm quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:b47aa41d9f732ae42fd4a9f607caecf16478eeb000c5c1f6b8c869b096dcc48b ls /usr/share/rpm-ostree/extensions/
++ grep -oP 'kernel-rt-\K[0-9]+(\.[0-9]+)*-[0-9]+(\.[0-9]+)*\.[a-z0-9_]+(\.[a-z0-9_]+)*(?=\.rpm)'
+ node_kernel_rt=5.14.0-427.47.1.el9_4.x86_64
+ echo 'INFO: Node kernel-rt: 5.14.0-427.47.1.el9_4.x86_64'
INFO: Node kernel-rt: 5.14.0-427.47.1.el9_4.x86_64
++ get_driver_toolkit_release_file
++ driver_toolkit_release=/tmp/ci-artifacts_20250106124630/driver-toolkit-release.json
++ [[ ! -s /tmp/ci-artifacts_20250106124630/driver-toolkit-release.json ]]
++ echo /tmp/ci-artifacts_20250106124630/driver-toolkit-release.json
+ dtk_release_file=/tmp/ci-artifacts_20250106124630/driver-toolkit-release.json
++ cat /tmp/ci-artifacts_20250106124630/driver-toolkit-release.json
++ jq -r .RT_KERNEL_VERSION
++ cut -d+ -f1
+ dtk_kernel_rt=5.14.0-427.42.1.el9_4.x86_64
+ echo 'INFO: driver-toolkit kernel-rt: 5.14.0-427.42.1.el9_4.x86_64'
INFO: driver-toolkit kernel-rt: 5.14.0-427.42.1.el9_4.x86_64
+ echo 5.14.0-427.42.1.el9_4.x86_64
+ echo 5.14.0-427.47.1.el9_4.x86_64
+ [[ 5.14.0-427.42.1.el9_4.x86_64 != 5.14.0-427.47.1.el9_4.x86_64 ]]
+ echo 'ERROR: driver-toolkit and node kernel-rt version mismatch: (5.14.0-427.42.1.el9_4.x86_64 !=  5.14.0-427.47.1.el9_4.x86_64)'
ERROR: driver-toolkit and node kernel-rt version mismatch: (5.14.0-427.42.1.el9_4.x86_64 !=  5.14.0-427.47.1.el9_4.x86_64)
+ exit 1
+ cleanup
+ oc delete ns openshift-e2e-driver-toolkit
namespace "openshift-e2e-driver-toolkit" deleted

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2025
@ybettan
Copy link
Member Author

ybettan commented Jan 6, 2025

/assign @yevgeny-shnaidman @TomerNewman

@ybettan
Copy link
Member Author

ybettan commented Jan 6, 2025

This job runs on every nightly and gated by ART. A nightly with this job failing cannot be promoted to a z-stream. After merge, it will also gate broken releases (with a broken DTK image) from being promoted into a z-stream.

@yevgeny-shnaidman
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
Copy link

openshift-ci bot commented Jan 6, 2025

@ybettan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ybettan ybettan changed the title Extending the e2e job to validate the kernel-rt versions matches. MGMT-19632: Extending the e2e job to validate the kernel-rt versions matches. Jan 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2025

@ybettan: This pull request references MGMT-19632 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

We are validating that the DTK image contain the kernel packages matching the running kernel on the node.

This commit is extending the job to also compare DTK's kernel-rt packages and the RT kernel that the node will reboot into if configured to do so.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 6, 2025
@ybettan
Copy link
Member Author

ybettan commented Jan 6, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2025

@ybettan: This pull request references MGMT-19632 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 606c3ee into openshift:master Jan 6, 2025
8 checks passed
@ybettan ybettan deleted the kernel-rt branch January 6, 2025 23:05
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: driver-toolkit
This PR has been included in build driver-toolkit-container-v4.19.0-202501070436.p0.g606c3ee.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants