Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1797020: [ART-1566] Dockerfile.product: Change node headers to v12 #5400

Merged
merged 1 commit into from
May 14, 2020
Merged

Bug 1797020: [ART-1566] Dockerfile.product: Change node headers to v12 #5400

merged 1 commit into from
May 14, 2020

Conversation

sosiouxme
Copy link
Member

Coordinate with ART via https://issues.redhat.com/browse/ART-1566 to get this change into master.

spadgett
spadgett approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold

@sosiouxme Thanks, feel free to remove the hold if this is ready

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2020
@spadgett spadgett added this to the v4.5 milestone May 12, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sosiouxme, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2020
@spadgett
Copy link
Member

/refresh

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@spadgett spadgett changed the title [ART-1566] Dockerfile.product: Change node headers to v12 Bug 1797020: [ART-1566] Dockerfile.product: Change node headers to v12 May 12, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 12, 2020
@openshift-ci-robot
Copy link
Contributor

@sosiouxme: This pull request references Bugzilla bug 1797020, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1797020: [ART-1566] Dockerfile.product: Change node headers to v12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 12, 2020
@spadgett
Copy link
Member

/test

@openshift-ci-robot
Copy link
Contributor

@spadgett: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test analyze
  • /test backend
  • /test e2e-gcp-console
  • /test frontend
  • /test images

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

/test all

@sosiouxme
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2020
sosiouxme added a commit to openshift-eng/ocp-build-data that referenced this pull request May 14, 2020
@sosiouxme
openshift-enterprise-console: base on nodejs-12
cfa6559 
This anticipates the merge of openshift/console#5400
@openshift-merge-robot openshift-merge-robot merged commit a99ec4d into openshift:master May 14, 2020
@openshift-ci-robot
Copy link
Contributor

@sosiouxme: All pull requests linked via external trackers have merged: openshift/console#5400. Bugzilla bug 1797020 has been moved to the MODIFIED state.

In response to this:

Bug 1797020: [ART-1566] Dockerfile.product: Change node headers to v12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sosiouxme
Copy link
Member Author

It worked... https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1193792

sosiouxme added a commit to openshift-eng/ocp-build-data that referenced this pull request Jun 3, 2020
@sosiouxme
openshift-enterprise-console: base on nodejs-12
476d4b9 
This anticipates the merge of openshift/console#5400
@sosiouxme
Copy link
Member Author

/cherrypick 4.4

@openshift-cherrypick-robot
Copy link

@sosiouxme: cannot checkout 4.4: error checking out 4.4: exit status 1. output: error: pathspec '4.4' did not match any file(s) known to git.

In response to this:

/cherrypick 4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sosiouxme
Copy link
Member Author

/cherrypick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 14, 2020
Merged
@openshift-cherrypick-robot
Copy link

@sosiouxme: new pull request created: #5979

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.
6 participants
@sosiouxme @openshift-ci-robot @spadgett @openshift-cherrypick-robot @openshift-merge-robot @joepvd