Skip to content

Comments

CONSOLE-5100: Remove support for PatternFly 5#16056

Open
logonoff wants to merge 1 commit intoopenshift:mainfrom
logonoff:CONSOLE-5100-patternfly5
Open

CONSOLE-5100: Remove support for PatternFly 5#16056
logonoff wants to merge 1 commit intoopenshift:mainfrom
logonoff:CONSOLE-5100-patternfly5

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Feb 24, 2026

Future releases of PatternFly will include a theme which will look better if all components use PatternFly 6 components.

In the next version of OpenShift we aim to adopt this release of PatternFly, we should drop PatternFly 5 as preparation.

Summary by CodeRabbit

  • Chores
    • Removed all PatternFly 5 package dependencies, CSS imports, and styling definitions from the application
    • Cleaned up legacy PatternFly 5 SCSS styling overrides and ancillary styling configurations
    • Updated application build configuration and dependency validation checks to support only PatternFly 6
    • Removed all remaining PatternFly 5 references from webpack configuration and npm packaging setup

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 24, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 24, 2026

@logonoff: This pull request references CONSOLE-5100 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Future releases of PatternFly will include a theme which will look better if all components use PatternFly 6 components.

In the next version of OpenShift we aim to adopt this release of PatternFly, we should drop PatternFly 5 as preparation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 24, 2026

@logonoff: This pull request references CONSOLE-5100 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Future releases of PatternFly will include a theme which will look better if all components use PatternFly 6 components.

In the next version of OpenShift we aim to adopt this release of PatternFly, we should drop PatternFly 5 as preparation.

Summary by CodeRabbit

  • Chores
  • Removed all PatternFly 5 package dependencies, CSS imports, and styling definitions from the application
  • Cleaned up legacy PatternFly 5 SCSS styling overrides and ancillary styling configurations
  • Updated application build configuration and dependency validation checks to support only PatternFly 6
  • Removed all remaining PatternFly 5 references from webpack configuration and npm packaging setup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhadvig and sg00dwin February 24, 2026 15:03
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/sdk Related to console-plugin-sdk approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 24, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 917eedd and 7ef21b1.

⛔ Files ignored due to path filters (1)
  • frontend/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (6)
  • frontend/package.json
  • frontend/packages/console-dynamic-plugin-sdk/release-notes/4.22.md
  • frontend/public/style.scss
  • frontend/public/style/ancillary/_patternfly5.scss
  • frontend/scripts/check-patternfly-modules.ts
  • frontend/webpack.config.ts
💤 Files with no reviewable changes (4)
  • frontend/public/style.scss
  • frontend/package.json
  • frontend/scripts/check-patternfly-modules.ts
  • frontend/public/style/ancillary/_patternfly5.scss

📝 Walkthrough

Walkthrough

This pull request removes PatternFly 5.x support across the frontend, consolidating the codebase to PatternFly 6.x exclusively. Changes include removing the PatternFly 5 npm alias from package.json dependencies, deleting ancillary PF5 SCSS styling (448 lines of variable mappings and form-control overrides), removing PF5 style imports from the main stylesheet and webpack entry point, updating release notes to document the removal, and eliminating PatternFly v5 from the module validation script. The consolidation streamlines the build configuration and reduces CSS complexity.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title clearly and concisely describes the main change: removal of PatternFly 5 support across the codebase, with specific ticket reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@logonoff logonoff force-pushed the CONSOLE-5100-patternfly5 branch from 7ef21b1 to d9a0503 Compare February 24, 2026 15:10
@rhamilto
Copy link
Member

We have some instances of pf-v5 that need to be removed as well.

@logonoff logonoff force-pushed the CONSOLE-5100-patternfly5 branch from d9a0503 to fe83d47 Compare February 24, 2026 15:51
@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Feb 24, 2026
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few CSS nits

@logonoff logonoff force-pushed the CONSOLE-5100-patternfly5 branch from fe83d47 to 854b41f Compare February 24, 2026 16:18
@rhamilto
Copy link
Member

/lgtm
/hold for the time being

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/sdk Related to console-plugin-sdk do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants