CONSOLE-5100: Remove support for PatternFly 5#16056
CONSOLE-5100: Remove support for PatternFly 5#16056logonoff wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@logonoff: This pull request references CONSOLE-5100 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@logonoff: This pull request references CONSOLE-5100 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (4)
📝 WalkthroughWalkthroughThis pull request removes PatternFly 5.x support across the frontend, consolidating the codebase to PatternFly 6.x exclusively. Changes include removing the PatternFly 5 npm alias from package.json dependencies, deleting ancillary PF5 SCSS styling (448 lines of variable mappings and form-control overrides), removing PF5 style imports from the main stylesheet and webpack entry point, updating release notes to document the removal, and eliminating PatternFly v5 from the module validation script. The consolidation streamlines the build configuration and reduces CSS complexity. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
7ef21b1 to
d9a0503
Compare
|
We have some instances of |
d9a0503 to
fe83d47
Compare
frontend/public/components/factory/Table/_virtualized-table.scss
Outdated
Show resolved
Hide resolved
fe83d47 to
854b41f
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Future releases of PatternFly will include a theme which will look better if all components use PatternFly 6 components.
In the next version of OpenShift we aim to adopt this release of PatternFly, we should drop PatternFly 5 as preparation.
Summary by CodeRabbit