Skip to content

Comments

CONSOLE-5094: Delete Dockerfile.product.nodejs#16047

Open
logonoff wants to merge 1 commit intoopenshift:mainfrom
logonoff:CONSOLE-5904-Dockerfile.product.nodejs
Open

CONSOLE-5094: Delete Dockerfile.product.nodejs#16047
logonoff wants to merge 1 commit intoopenshift:mainfrom
logonoff:CONSOLE-5904-Dockerfile.product.nodejs

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Feb 19, 2026

Given this file uses a Node.js 8 base image for OpenShift 3 (which is way too old for anything we need), I think we can safely assume that nobody is using this at all

Summary by CodeRabbit

  • Chores
    • Removed legacy build infrastructure components from the build configuration.

@openshift-ci-robot
Copy link
Contributor

@logonoff: No Jira issue with key CONSOLE-5904 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Given this file uses a Node.js 8 base image (which is way too old for anything we need), I think we can safely assume that nobody is using this at all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff changed the title CONSOLE-5904: Delete Dockerfile.product.nodejs CONSOLE-5094: Delete Dockerfile.product.nodejs Feb 19, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 19, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2026

@logonoff: This pull request references CONSOLE-5094 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Given this file uses a Node.js 8 base image (which is way too old for anything we need), I think we can safely assume that nobody is using this at all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from rhamilto and spadgett February 19, 2026 18:03
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

📝 Walkthrough

Walkthrough

This change removes the NodeJS 8 builder stage from Dockerfile.product.nodejs, eliminating the base image declaration, workspace setup, frontend build script invocation (./build-frontend.sh), temporary file cleanup operations, and all image metadata labels. The resulting Dockerfile lacks a Node.js build stage and associated image metadata. This represents a significant structural modification to the frontend build process configuration, though the changeset provides no context regarding build stage relocation or alternative build mechanisms.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the specific file being deleted (Dockerfile.product.nodejs) and the action (Delete), directly matching the changeset content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2026

@logonoff: This pull request references CONSOLE-5094 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Given this file uses a Node.js 8 base image (which is way too old for anything we need), I think we can safely assume that nobody is using this at all

Summary by CodeRabbit

  • Chores
  • Removed legacy build infrastructure components from the build configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Feb 19, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2026

@logonoff: This pull request references CONSOLE-5094 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Given this file uses a Node.js 8 base image for OpenShift 3 (which is way too old for anything we need), I think we can safely assume that nobody is using this at all

Summary by CodeRabbit

  • Chores
  • Removed legacy build infrastructure components from the build configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the CONSOLE-5904-Dockerfile.product.nodejs branch from 2a1c81c to 9efcfe9 Compare February 19, 2026 20:34
@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2026
@jhadvig
Copy link
Member

jhadvig commented Feb 24, 2026

/label acknowledge-critical-fixes-only
/approve

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 24, 2026
@logonoff
Copy link
Member Author

changes are a noop, Dockerfile.product.nodejs is already broken (and has been for years), so it must be unused

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 24, 2026
@openshift-ci-robot
Copy link
Contributor

@logonoff: The verified label has been added.

Details

In response to this:

changes are a noop, Dockerfile.product.nodejs is already broken (and has been for years), so it must be unused

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 9efcfe9 link unknown /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants