Skip to content

Comments

CONSOLE-5093: Remove support for deprecated extensions#16043

Open
logonoff wants to merge 4 commits intoopenshift:mainfrom
logonoff:CONSOLE-5093-s3e8-the-merger
Open

CONSOLE-5093: Remove support for deprecated extensions#16043
logonoff wants to merge 4 commits intoopenshift:mainfrom
logonoff:CONSOLE-5093-s3e8-the-merger

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Feb 18, 2026

  • Removed console.page/resource/tab (deprecated in 4.11) - use console.tab/horizontalNav instead
  • Removed console.dashboards/overview/detail/item (deprecated in 4.12) - use console.dashboards/custom/overview/detail/item instead

Summary by CodeRabbit

  • Breaking Changes

    • Removed support for console.page/resource/tab extension type; migrate to console.tab/horizontalNav
    • Removed support for console.dashboards/overview/detail/item extension type; migrate to console.dashboards/custom/overview/detail/item
    • Updated extension structure for affected tabs and dashboard detail items
  • Documentation

    • Added migration guides and examples for deprecated extension types

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 18, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 18, 2026

@logonoff: This pull request references CONSOLE-5093 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  • Removed console.page/resource/tab (deprecated in 4.11) - use console.tab/horizontalNav instead
  • Removed console.dashboards/overview/detail/item ([deprecated in 4.12][https://github.com/openshift/console/commit/e3d07695c61506b14e8b39c370bd8afa7a42a9dc]) - use console.dashboards/custom/overview/detail/item instead

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the CONSOLE-5093-s3e8-the-merger branch from df2bb55 to ce3ab44 Compare February 18, 2026 18:59
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 18, 2026

@logonoff: This pull request references CONSOLE-5093 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  • Removed console.page/resource/tab (deprecated in 4.11) - use console.tab/horizontalNav instead
  • Removed console.dashboards/overview/detail/item (deprecated in 4.12) - use console.dashboards/custom/overview/detail/item instead

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhadvig and rawagner February 18, 2026 18:59
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Feb 18, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/dashboard Related to dashboard approved Indicates a PR has been approved by an approver from all required OWNERS files. component/sdk Related to console-plugin-sdk kind/demo-plugin Related to dynamic-demo-plugin plugin-api-changed Categorizes a PR as containing plugin API changes labels Feb 18, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

📝 Walkthrough

Walkthrough

This pull request removes support for two deprecated extension types: console.page/resource/tab and console.dashboards/overview/detail/item. The changes include deletion of the corresponding TypeScript type exports and type guards from the dynamic plugin SDK, removal of extension resolution logic from component implementations, updates to extension declarations using the new types (console.tab/horizontalNav and console.dashboards/custom/overview/detail/item), removal of the demo OverviewDetailItem component, and updates to documentation and release notes documenting the breaking changes.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: removing support for deprecated extensions (CONSOLE-5093), which aligns with all file modifications across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 18, 2026

@logonoff: This pull request references CONSOLE-5093 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  • Removed console.page/resource/tab (deprecated in 4.11) - use console.tab/horizontalNav instead
  • Removed console.dashboards/overview/detail/item (deprecated in 4.12) - use console.dashboards/custom/overview/detail/item instead

Summary by CodeRabbit

  • Breaking Changes

  • Removed support for console.page/resource/tab extension type; migrate to console.tab/horizontalNav

  • Removed support for console.dashboards/overview/detail/item extension type; migrate to console.dashboards/custom/overview/detail/item

  • Updated extension structure for affected tabs and dashboard detail items

  • Documentation

  • Added migration guides and examples for deprecated extension types

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@frontend/packages/console-dynamic-plugin-sdk/release-notes/4.22.md`:
- Around line 23-24: Fix the grammar in the sentence about the deprecated
extension: update the sentence referencing `console.page/resource/tab` and
`console.tab/horizontalNav` so it reads "deprecated in favor of
`console.tab/horizontalNav` extension" (i.e., insert the missing word "of"
before `console.tab/horizontalNav`).

@logonoff logonoff force-pushed the CONSOLE-5093-s3e8-the-merger branch 3 times, most recently from 2c4f88d to ed156c7 Compare February 18, 2026 19:47
@logonoff logonoff force-pushed the CONSOLE-5093-s3e8-the-merger branch from ed156c7 to e140c2f Compare February 19, 2026 20:40
@logonoff logonoff force-pushed the CONSOLE-5093-s3e8-the-merger branch from e140c2f to 94f15aa Compare February 23, 2026 21:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 94f15aa link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/sdk Related to console-plugin-sdk jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/demo-plugin Related to dynamic-demo-plugin plugin-api-changed Categorizes a PR as containing plugin API changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants