Skip to content

Comments

[WIP] CONSOLE-4447: Migrate console-app modals to modern PatternFly Modal components#16037

Open
rhamilto wants to merge 4 commits intoopenshift:mainfrom
rhamilto:CONSOLE-4447-app
Open

[WIP] CONSOLE-4447: Migrate console-app modals to modern PatternFly Modal components#16037
rhamilto wants to merge 4 commits intoopenshift:mainfrom
rhamilto:CONSOLE-4447-app

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Feb 17, 2026

Includes changes from #16015, which should merge first

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 17, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 17, 2026 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4447 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Includes changes from #16015, which should merge first

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2026
@openshift-ci openshift-ci bot requested review from Leo6Leo and rawagner February 17, 2026 15:59
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/knative Related to knative-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. component/metal3 Related to metal3-plugin component/olm Related to OLM component/shared Related to console-shared labels Feb 17, 2026
@rhamilto rhamilto changed the title [WIP] CONSOLE-4447: migrate console-app modals to modern PatternFly Modal components [WIP] CONSOLE-4447: Migrate console-app modals to modern PatternFly Modal components Feb 17, 2026
@rhamilto
Copy link
Member Author

rhamilto commented Feb 17, 2026

/retest

1 similar comment
@rhamilto
Copy link
Member Author

rhamilto commented Feb 18, 2026

/retest

@jhadvig jhadvig requested a review from sg00dwin February 18, 2026 14:14
@rhamilto
Copy link
Member Author

rhamilto commented Feb 19, 2026

/retest

@rhamilto rhamilto force-pushed the CONSOLE-4447-app branch 3 times, most recently from 6d0cd25 to b2c6e34 Compare February 19, 2026 20:28
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2026
rhamilto and others added 3 commits February 19, 2026 16:40
@rhamilto @claude
Update modal Cancel buttons to use variant="link"
edbbd36 
Update Cancel button variants from "secondary" to "link" in modern
PatternFly modals to follow PatternFly standards.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@rhamilto @claude
Migrate modals to modern PatternFly Modal and remove deprecated Modal…
fff846f 
… wrapper

- Migrate useCopyCodeModal, FavoriteButton, and TourStepComponent from
  deprecated Modal wrapper to modern PatternFly Modal components
- Remove deprecated Modal wrapper (packages/console-shared/src/components/modal/)
- Migrate CatalogDetailsModal and operator-hub-items from deprecated
  PatternFly Modal to modern Modal components
- Preserve ocs-modal CSS class for catalog modal positioning
- Fix FavoriteButton form submission bug by adding preventDefault
- Fix Guided Tour accessibility warning by closing Help dropdown and
  blurring focus before starting tour

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@rhamilto @claude
Migrate DeleteModal and related modals to modern PatternFly Modal
a3d3623 
- Migrate DeleteModal from deprecated factory/modal components to
  modern PatternFly v6 Modal components
- Create reusable ModalFooterWithAlerts component for alert display
- Update configure-count-modal and configure-machine-autoscaler-modal
  to use modern Modal components and ModalFooterWithAlerts

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2026
@rhamilto
Copy link
Member Author

rhamilto commented Feb 23, 2026

/retest

@rhamilto rhamilto force-pushed the CONSOLE-4447-app branch 2 times, most recently from 5f19c8b to c33da99 Compare February 23, 2026 17:10
@rhamilto
Migrate console-app modals to PatternFly v6 and replace error display…
2d50dca 
… components

This commit updates multiple modal components to use modern PatternFly v6
patterns and replaces deprecated error display components with the new
ModalFooterWithAlerts component.

Changes:
- Replace ModalErrorContent with ModalFooterWithAlerts in:
  - clone-pvc-modal.tsx
  - modify-vac-modal.tsx
  - ResourceLimitsModal.tsx
  - restore-pvc-modal.tsx
  - ConfigureUnschedulableModal.tsx
  - DeletePDBModal.tsx
- Remove onSubmit handlers from Form elements
- Move form submission to onClick handlers on submit buttons
- Add form attribute to submit buttons to associate with form id
- Fix Formik type compatibility in ResourceLimitsModal by wrapping
  handleSubmit in arrow function
- Delete unused SCSS files:
  - packages/console-app/src/components/modals/clone/_clone-pvc-modal.scss
  - packages/console-app/src/components/modals/restore-pvc/restore-pvc-modal.scss

All modals now follow the PatternFly "with form" pattern with consistent
error/alert display using ModalFooterWithAlerts.
@rhamilto
Copy link
Member Author

rhamilto commented Feb 23, 2026

/test backend

sg00dwin
sg00dwin approved these changes Feb 23, 2026
View reviewed changes
Copy link
Member

@sg00dwin sg00dwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

@rhamilto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 2d50dca link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhamilto
Copy link
Member Author

rhamilto commented Feb 24, 2026

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Feb 24, 2026

/assign @yapei

Tech debt, so assigning labels
/label px-approved
/label docs-approved

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 24, 2026 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4447 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/assign @yapei

Tech debt, so assigning labels
/label px-approved
/label docs-approved

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sg00dwin sg00dwin sg00dwin approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@sg00dwin sg00dwin

@yapei yapei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/knative Related to knative-plugin component/metal3 Related to metal3-plugin component/olm Related to OLM component/shared Related to console-shared do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @openshift-ci-robot @sg00dwin @yapei @openshift-merge-robot