Skip to content

CONSOLE-4619: Create ExternalLinkButton component and use it #15177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 3 commits into from
Jun 17, 2025
Merged

CONSOLE-4619: Create ExternalLinkButton component and use it #15177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68fb55f
CONSOLE-4619: Create new `ExternalLinkButton` component and use it
logonoff Jun 12, 2025
c487f63
CONSOLE-4619: ExternalLinkWithCopy link => href
logonoff Jun 14, 2025
e80f9f6
CONSOLE-4619: Migrate failing tests to RTL and improve ExternalLinkWi…
logonoff Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions frontend/__tests__/components/route-pages.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe(RouteLocation.displayName, () => {
const wrapper = shallow(<RouteLocation obj={route} />);
const externalLinkWrapper = wrapper.find(RouteLinkAndCopy).shallow();
expect(externalLinkWrapper.find(ExternalLinkWithCopy).exists()).toBe(true);
expect(externalLinkWrapper.find(ExternalLinkWithCopy).props().link).toContain('https:');
expect(externalLinkWrapper.find(ExternalLinkWithCopy).props().href).toContain('https:');
});

it('renders a http link when no TLS Settings', () => {
Expand Down Expand Up @@ -81,7 +81,7 @@ describe(RouteLocation.displayName, () => {
const wrapper = shallow(<RouteLocation obj={route} />);
const externalLinkWrapper = wrapper.find(RouteLinkAndCopy).shallow();
expect(externalLinkWrapper.find(ExternalLinkWithCopy).exists()).toBe(true);
expect(externalLinkWrapper.find(ExternalLinkWithCopy).props().link).toContain('http:');
expect(externalLinkWrapper.find(ExternalLinkWithCopy).props().href).toContain('http:');
});

it('renders oldest admitted ingress', () => {
Expand Down Expand Up @@ -130,7 +130,7 @@ describe(RouteLocation.displayName, () => {
const wrapper = shallow(<RouteLocation obj={route} />);
const externalLinkWrapper = wrapper.find(RouteLinkAndCopy).shallow();
expect(externalLinkWrapper.find(ExternalLinkWithCopy).exists()).toBe(true);
expect(externalLinkWrapper.find(ExternalLinkWithCopy).props().link).toContain(
expect(externalLinkWrapper.find(ExternalLinkWithCopy).props().href).toContain(
'http://www.example.com',
);
});
Expand Down Expand Up @@ -171,7 +171,7 @@ describe(RouteLocation.displayName, () => {
const wrapper = shallow(<RouteLocation obj={route} />);
const externalLinkWrapper = wrapper.find(RouteLinkAndCopy).shallow();
expect(externalLinkWrapper.find(ExternalLinkWithCopy).exists()).toBe(true);
expect(externalLinkWrapper.find(ExternalLinkWithCopy).props().link).toContain('\\mypath');
expect(externalLinkWrapper.find(ExternalLinkWithCopy).props().href).toContain('\\mypath');
});

it('renders Subdomain', () => {
Expand Down
262 changes: 0 additions & 262 deletions ...kages/console-app/src/__tests__/network-policies/network-policy-selector-preview.spec.tsx
View file
Open in desktop

This file was deleted.

19 changes: 5 additions & 14 deletions frontend/packages/console-app/src/components/guided-tour/GuidedTourText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Trans, useTranslation } from 'react-i18next';
import { useK8sWatchResource } from '@console/internal/components/utils/k8s-watch-hook';
import { ConsoleLinkModel } from '@console/internal/models';
import { K8sResourceKind, referenceForModel } from '@console/internal/module/k8s';
import { ExternalLink } from '@console/shared/src/components/links/ExternalLink';

const HelpTourText: React.FC = () => {
const { t } = useTranslation();
Expand Down Expand Up @@ -38,23 +39,13 @@ export const FinishTourText: React.FC = () => {
return (
<Trans t={t} ns="console-app">
Stay up-to-date with everything OpenShift on our{' '}
<a
href={openshiftBlogLink}
target="_blank"
rel="noopener noreferrer"
data-test="openshift-blog-link"
>
<ExternalLink href={openshiftBlogLink} data-test="openshift-blog-link">
blog
</a>{' '}
</ExternalLink>{' '}
or continue to learn more in our{' '}
<a
href={openshiftHelpBase}
target="_blank"
rel="noopener noreferrer"
data-test="openshift-docs-link"
>
<ExternalLink href={openshiftHelpBase} data-test="openshift-help-link">
documentation
</a>
</ExternalLink>
.
</Trans>
);
Expand Down
Loading