Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.17] OCPBUGS-52205: Show Observe section without PROMETHEUS and MONITORING flags #14811

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-52205: Show Observe section without PROMETHEUS and MONITORING flags #14811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Show Observe section without PROMETHEUS and MONITORING flags 
Currently, the Observe section is only shown to users which have the
`PROMETHEUS`, `MONITORING` and `CAN_GET_NS` flags.

Some dynamic plugins, for example distributed tracing and logging, add a
new link to the Observe section, which should be visible to all users -
even without the `PROMETHEUS`, `MONITORING` and `CAN_GET_NS` flags. Therefore this
PR removes the requirement on this flags.

I checked the links in the section, and the monitoring-related links
(Alerting, Metrics, Dashboards, Targets) set the required permissions
(`PROMETHEUS`, `MONITORING` and `CAN_GET_NS`) on the `console.navigation/href` already:
https://github.com/openshift/monitoring-plugin/blob/6b92084514ea9007d7d797f7699eab19e0c2f2fc/web/console-extensions.json

In case the Observe section is empty, it is hidden:
https://github.com/openshift/console/blob/855f949121cefb3ea63b17ebf91e6bdcdc60d9c8/frontend/packages/console-app/src/components/nav/NavSection.tsx#L57-L60

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
  • Loading branch information
@andreasgerstmayr
andreasgerstmayr authored and openshift-cherrypick-robot committed Mar 3, 2025
commit 89935f2c002a3288fc8dfa0b2c4b4ef8f9125105
3 changes: 0 additions & 3 deletions frontend/packages/console-app/console-extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,9 +736,6 @@
"dataAttributes": {
"data-quickstart-id": "qs-nav-monitoring"
}
},
"flags": {
"required": ["PROMETHEUS", "MONITORING", "CAN_GET_NS"]
}
},
{
Expand Down