Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-7769: Add Getting started section in project Overview page #14792

Merged
merged 1 commit into from
Feb 28, 2025
Merged

ODC-7769: Add Getting started section in project Overview page #14792

merged 1 commit into from
Feb 28, 2025
+51 −55

Conversation

vikram-raj
Copy link
Member

@vikram-raj vikram-raj commented Feb 24, 2025 •
edited
Loading

Add getting started section on the project overview page

image

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 24, 2025 •
edited by openshift-ci bot
Loading

@vikram-raj: This pull request references ODC-7769 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Add getting started section on the project overview page

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Feb 24, 2025
@vikram-raj
Copy link
Member Author

/cc @lokanandaprabhu

@vikram-raj vikram-raj requested a review from logonoff February 25, 2025 06:14
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2025 •
edited by openshift-ci bot
Loading

@vikram-raj: This pull request references ODC-7769 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Add getting started section on the project overview page

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lokanandaprabhu
lokanandaprabhu reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@lokanandaprabhu lokanandaprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under "Explore new developer features " section, onClick of "Start building your application quickly in topology" , topology menu is not highlighted in left navigation menu.

Screen.Recording.2025-02-25.at.3.34.34.PM.mov

@vikram-raj
Copy link
Member Author

Under "Explore new developer features " section, onClick of "Start building your application quickly in topology" , topology menu is not highlighted in left navigation menu.

It is highlighted but the workloads nav item is not expanded if the child nav item is selected.

lokanandaprabhu
lokanandaprabhu approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@lokanandaprabhu lokanandaprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@vikram-raj
Copy link
Member Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Feb 25, 2025
logonoff
logonoff approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanketpathak
Copy link
Contributor

Verified in a cluster with admin and non-admin users

Screenshot From 2025-02-26 21-45-05
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 27, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2025 •
edited by openshift-ci bot
Loading

@vikram-raj: This pull request references ODC-7769 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Add getting started section on the project overview page

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vikram-raj
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9d09302 and 2 for PR HEAD 956213e in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9d09302 and 2 for PR HEAD 956213e in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 28, 2025

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e9d6ead into openshift:main Feb 28, 2025
8 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.19.0-202502280209.p0.ge9d6ead.assembly.stream.el9.
All builds following this will include this PR.

@vikram-raj vikram-raj deleted the odc-7769 branch February 28, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logonoff logonoff logonoff approved these changes

@lokanandaprabhu lokanandaprabhu lokanandaprabhu approved these changes

@Lucifergene Lucifergene Awaiting requested review from Lucifergene

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@logonoff logonoff

@lokanandaprabhu lokanandaprabhu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vikram-raj @openshift-ci-robot @sanketpathak @openshift-bot @logonoff @lokanandaprabhu