-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODC-7680: Remove SeriesButton
, QueryTable
#14363
base: master
Are you sure you want to change the base?
Conversation
@logonoff: This pull request references ODC-7680 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@logonoff: This pull request references ODC-7680 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@logonoff: This pull request references ODC-7680 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
`SeriesButton` and `QueryTable` do not appear to be used anywhere within the openshift/console and openshift/monitoring-plugin repos, and `QueryTable` is using deprecated PatternFly Table components
dca2f01
to
c5ac97c
Compare
/retest |
CC @jgbernalp, @zhuje, @PeterYurkovich Is it OK to remove these now? |
okay to remove |
@logonoff: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jgbernalp, logonoff The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adding labels because this is debt /label px-approved |
Fixes:
https://issues.redhat.com/browse/ODC-7680
Solution Description:
SeriesButton
andQueryTable
do not appear to be used anywhere within the openshift/console and openshift/monitoring-plugin repos, andQueryTable
is using deprecated PatternFly Table componentsScreen shots / Gifs for design review:
n/a
Unit test coverage report:
unchanged
Test setup:
n/a
Browser conformance:
This pr is 3/4 of ODC-7680 story as each file is being split into a separate PR.