Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-7680: Remove SeriesButton, QueryTable #14363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Oct 2, 2024

Fixes:

https://issues.redhat.com/browse/ODC-7680

Solution Description:

SeriesButton and QueryTable do not appear to be used anywhere within the openshift/console and openshift/monitoring-plugin repos, and QueryTable is using deprecated PatternFly Table components

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

  • Chrome
  • Firefox
  • Safari

This pr is 3/4 of ODC-7680 story as each file is being split into a separate PR.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2024

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7680

Solution Description:

SeriesButton and QueryTable do not appear to be used anywhere within the openshift/console and openshift/monitoring-plugin repos, and QueryTable is using deprecated PatternFly Table components

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

  • Chrome
  • Firefox
  • Safari

This pr is 3/4 of ODC-7680 story as each file is being split into a separate PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2024

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7680

Solution Description:

SeriesButton and QueryTable do not appear to be used anywhere within the openshift/console and openshift/monitoring-plugin repos, and QueryTable is using deprecated PatternFly Table components

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

  • Chrome
  • Firefox
  • Safari

This pr is 3/4 of ODC-7680 story as each file is being split into a separate PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from kyoto and spadgett October 2, 2024 20:00
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/monitoring Related to monitoring labels Oct 2, 2024
@logonoff
Copy link
Member Author

logonoff commented Oct 2, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2024

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

`SeriesButton` and `QueryTable` do not appear to be used anywhere within the openshift/console and openshift/monitoring-plugin repos, and `QueryTable` is using deprecated PatternFly Table components
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Oct 2, 2024
@logonoff
Copy link
Member Author

logonoff commented Oct 2, 2024

/retest

@kyoto
Copy link
Member

kyoto commented Oct 3, 2024

CC @jgbernalp, @zhuje, @PeterYurkovich

Is it OK to remove these now?

@zhuje
Copy link
Contributor

zhuje commented Oct 3, 2024

okay to remove

Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgbernalp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jgbernalp, logonoff
Once this PR has been reviewed and has the lgtm label, please assign vojtechszocs for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logonoff
Copy link
Member Author

logonoff commented Oct 4, 2024

adding labels because this is debt

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/monitoring Related to monitoring docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants