CONSOLE-4287: Restore kubevirt extensions for the topology plugin #14360

pcbailey · 2024-10-02T01:44:11Z

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/CONSOLE-4287

Screenshots

Before

After

openshift-ci-robot · 2024-10-02T01:44:14Z

@pcbailey: This pull request references CNV-45158 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/CNV-45158

Screenshots

Before

After

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-10-02T02:09:08Z

@pcbailey: This pull request references CNV-45158 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/OCPBUGS-42672

Screenshots

Before

After

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-10-02T02:09:15Z

@pcbailey: This pull request references Jira Issue OCPBUGS-42672, which is invalid:

expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/OCPBUGS-42672

Screenshots

Before

After

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

upalatucci · 2024-10-02T11:02:27Z

/jira refresh

openshift-ci-robot · 2024-10-02T11:02:33Z

@upalatucci: This pull request references Jira Issue OCPBUGS-42672, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

frontend/packages/kubevirt-plugin/OWNERS

pcbailey · 2024-10-02T14:57:26Z

/jira refresh

openshift-ci-robot · 2024-10-02T14:57:31Z

@pcbailey: This pull request references Jira Issue OCPBUGS-42672, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

upalatucci · 2024-10-03T12:58:14Z

/lgtm

upalatucci · 2024-10-03T12:58:40Z

/approve

yapei · 2024-11-07T08:17:52Z

VirtualMachines can be shown in topology view but I'm consistently seeing Uncaught runtime errors when navigating through virtualization pages, here is one recording
I'm running following bridge commands locally

./bin/bridge -plugins kubevirt-plugin=http://localhost:9001 -i18n-namespaces=plugin__kubevirt-plugin

runtime-error.mov

opayne1

Hi! I noticed a few docs related things. Let me know if you have any questions!

frontend/packages/kubevirt-plugin/locales/en/kubevirt-plugin.json

...ackages/kubevirt-plugin/src/kubevirt-dependencies/components/alerts/PendingChangesAlerts.tsx

frontend/packages/kubevirt-plugin/src/kubevirt-dependencies/components/vm/menu-actions.tsx

frontend/packages/kubevirt-plugin/src/kubevirt-dependencies/constants/vm-status-messages.ts

upalatucci · 2024-11-13T08:20:45Z

@yapei i think this pr is not correlated to the error. We are experiencing the issue even on console latest

yapei · 2024-11-14T02:13:14Z

Thanks @upalatucci You are right, I tried on latest console master and see the same error
Regarding this PR changes, everything looks good so far

/label qe-approved

openshift-ci-robot · 2024-11-14T02:13:20Z

@pcbailey: This pull request references CONSOLE-4287 which is a valid jira issue.

In response to this:

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/CONSOLE-4287

Screenshots

Before

After

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

upalatucci · 2024-11-25T14:11:24Z

/lgtm

pcbailey · 2024-11-25T16:06:46Z

/retest

openshift-ci · 2024-11-26T12:35:55Z

New changes are detected. LGTM label has been removed.

pcbailey · 2024-11-26T14:58:30Z

/retest

pcbailey · 2024-11-26T20:58:50Z

/retest

pcbailey · 2024-11-27T20:27:33Z

/retest

pcbailey · 2024-12-03T13:39:27Z

/retest

pcbailey · 2024-12-03T23:03:01Z

/retest

pcbailey · 2024-12-05T11:25:18Z

/retest

rhamilto · 2024-12-11T13:42:24Z

...kages/kubevirt-plugin/src/kubevirt-dependencies/components/FilteredSelect/FilteredSelect.tsx

+/* eslint-disable array-callback-return, consistent-return */
+import * as React from 'react';
+import {
+  Select as SelectDeprecated,


Any deprecated components need to be removed and replaced with the PF5 equivalent; otherwise restoring this PR as is will block the upgrade to PF6.

spadgett

/hold

Adding a hold since this contains deprecated PF 5 components that will block the PF 6 upgrade. But the right thing is to fix this in the kubevirt dynamic plugin if possible. We should carefully consider whether we want to add 17k lines of code back to the console repo, even if it's temporary.

openshift-ci · 2024-12-12T14:26:14Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pcbailey, upalatucci
Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

frontend/OWNERS
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-02-18T00:06:29Z

@pcbailey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/frontend	`9ab19c4`	link	true	`/test frontend`
ci/prow/okd-scos-images	`9ab19c4`	link	true	`/test okd-scos-images`
ci/prow/e2e-gcp-console	`9ab19c4`	link	true	`/test e2e-gcp-console`
ci/prow/backend	`9ab19c4`	link	true	`/test backend`
ci/prow/images	`9ab19c4`	link	true	`/test images`
ci/prow/analyze	`9ab19c4`	link	true	`/test analyze`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2024

openshift-ci bot requested review from florkbr and christoph-jerolimov October 2, 2024 01:44

openshift-ci bot added component/backend Related to backend component/core Related to console core functionality component/topology Related to topology do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Oct 2, 2024

pcbailey changed the title ~~CNV-45158: Restore kubevirt extensions for the topology plugin~~ OCPBUGS-42672: Restore kubevirt extensions for the topology plugin Oct 2, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 2, 2024

upalatucci approved these changes Oct 2, 2024

View reviewed changes

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 2, 2024

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 2, 2024

openshift-ci bot requested a review from yapei October 2, 2024 11:02

upalatucci reviewed Oct 2, 2024

View reviewed changes

frontend/packages/kubevirt-plugin/OWNERS Outdated Show resolved Hide resolved

upalatucci reviewed Oct 2, 2024

View reviewed changes

frontend/packages/kubevirt-plugin/OWNERS Outdated Show resolved Hide resolved

pcbailey force-pushed the restore-kubevirt-topology-extensions branch from 931a9b3 to 03de011 Compare October 2, 2024 13:00

openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 2, 2024

upalatucci approved these changes Oct 2, 2024

View reviewed changes

openshift-ci bot assigned upalatucci Oct 3, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2024

openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 3, 2024

openshift-ci bot assigned yapei Nov 6, 2024

opayne1 reviewed Nov 12, 2024

View reviewed changes

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 14, 2024

pcbailey force-pushed the restore-kubevirt-topology-extensions branch from 03de011 to 9ecc7c1 Compare November 25, 2024 14:06

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024

pcbailey force-pushed the restore-kubevirt-topology-extensions branch from 9ecc7c1 to feda04c Compare November 26, 2024 12:35

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024

pcbailey force-pushed the restore-kubevirt-topology-extensions branch 2 times, most recently from 4e54335 to 3711702 Compare November 27, 2024 13:50

Restore kubevirt extensions for topology

9ab19c4

pcbailey force-pushed the restore-kubevirt-topology-extensions branch from 3711702 to 9ab19c4 Compare December 5, 2024 03:04

rhamilto reviewed Dec 11, 2024

View reviewed changes

spadgett requested changes Dec 12, 2024

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2024

CONSOLE-4287: Restore kubevirt extensions for the topology plugin #14360

Are you sure you want to change the base?

CONSOLE-4287: Restore kubevirt extensions for the topology plugin #14360

Conversation

pcbailey commented Oct 2, 2024 • edited Loading

Screenshots

Before

After

openshift-ci-robot commented Oct 2, 2024 • edited by openshift-ci bot Loading

Screenshots

Before

After

openshift-ci-robot commented Oct 2, 2024 • edited by openshift-ci bot Loading

Screenshots

Before

After

openshift-ci-robot commented Oct 2, 2024

Screenshots

Before

After

upalatucci commented Oct 2, 2024

openshift-ci-robot commented Oct 2, 2024

pcbailey commented Oct 2, 2024

openshift-ci-robot commented Oct 2, 2024

upalatucci commented Oct 3, 2024

upalatucci commented Oct 3, 2024

yapei commented Nov 7, 2024 • edited Loading

opayne1 left a comment

Choose a reason for hiding this comment

upalatucci commented Nov 13, 2024

yapei commented Nov 14, 2024

openshift-ci-robot commented Nov 14, 2024 • edited by openshift-ci bot Loading

Screenshots

Before

After

upalatucci commented Nov 25, 2024

pcbailey commented Nov 25, 2024

openshift-ci bot commented Nov 26, 2024

pcbailey commented Nov 26, 2024

pcbailey commented Nov 26, 2024

pcbailey commented Nov 27, 2024

pcbailey commented Dec 3, 2024

pcbailey commented Dec 3, 2024

pcbailey commented Dec 5, 2024

rhamilto Dec 11, 2024 • edited Loading

Choose a reason for hiding this comment

spadgett left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Dec 12, 2024

openshift-ci bot commented Feb 18, 2025

pcbailey commented Oct 2, 2024 •

edited

Loading

openshift-ci-robot commented Oct 2, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 2, 2024 •

edited by openshift-ci bot

Loading

yapei commented Nov 7, 2024 •

edited

Loading

openshift-ci-robot commented Nov 14, 2024 •

edited by openshift-ci bot

Loading

rhamilto Dec 11, 2024 •

edited

Loading