Skip to content

Commit

Permalink
Merge pull request #14806 from rhamilto/CONSOLE-4484
Browse files Browse the repository at this point in the history
CONSOLE-4484: follow on fix to ensure Bottom ConsoleNotification are …
  • Loading branch information
openshift-merge-bot[bot] authored Mar 3, 2025
2 parents cdb9979 + f6fb390 commit e487b63
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe(`${crd} CRD`, () => {
cy.visit(`/k8s/cluster/console.openshift.io~v1~${crd}/${name}`);
detailsPage.titleShouldContain(name);

cy.get(notification).contains(text).should('exist');
cy.get(notification).contains(text).should('exist').and('be.visible');

cy.visit(`/k8s/cluster/console.openshift.io~v1~${crd}/${name}/yaml`);
yamlEditor.isLoaded();
Expand All @@ -74,7 +74,7 @@ describe(`${crd} CRD`, () => {
});
});

cy.get(altNotification).contains(altText).should('exist');
cy.get(altNotification).contains(altText).should('exist').and('be.visible');

cy.visit(`/k8s/cluster/console.openshift.io~v1~${crd}`);
listPage.rows.shouldBeLoaded();
Expand Down
2 changes: 1 addition & 1 deletion frontend/public/models/yaml-templates.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,7 @@ spec:
href: 'https://www.example.com'
text: Optional link text
color: '#fff'
backgroundColor: '#0088ce'
backgroundColor: '#0066cc'
`,
)
.setIn(
Expand Down
3 changes: 3 additions & 0 deletions frontend/public/style/_layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ html,
body,
#app,
.pf-v6-c-drawer {
display: flex;
flex-basis: 100%;
flex-direction: column;
height: 100%;
}

Expand Down

0 comments on commit e487b63

Please sign in to comment.