Skip to content

ART-12521: update go mod dependency for konflux#973

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ashwindasr:konflux-prefetch-update
Apr 7, 2025
Merged

ART-12521: update go mod dependency for konflux#973
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ashwindasr:konflux-prefetch-update

Conversation

@ashwindasr
Copy link
Contributor

Image build was failing on Konflux due to missing go mod dependencies.

2025-04-04 17:29:46,063 ERROR vendor directory changed after vendoring:
A	vendor/golang.org/x/sys/unix/dev_aix_ppc.go
A	vendor/golang.org/x/sys/unix/dev_aix_ppc64.go
A	vendor/golang.org/x/sys/unix/dev_zos.go
2025-04-04 17:29:50,718 ERROR PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.

Konflux ignores .gitignore files since its a possible security gap.

@ashwindasr ashwindasr changed the title update go mod dependency for konflux ART-12521: update go mod dependency for konflux Apr 4, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2025

@ashwindasr: This pull request references ART-12521 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Image build was failing on Konflux due to missing go mod dependencies.

2025-04-04 17:29:46,063 ERROR vendor directory changed after vendoring:
A	vendor/golang.org/x/sys/unix/dev_aix_ppc.go
A	vendor/golang.org/x/sys/unix/dev_aix_ppc64.go
A	vendor/golang.org/x/sys/unix/dev_zos.go
2025-04-04 17:29:50,718 ERROR PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.

Konflux ignores .gitignore files since its a possible security gap.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from TheRealJon and spadgett April 4, 2025 18:00
@ashwindasr
Copy link
Contributor Author

I wasn't sure if I could remove dev_*, so adding the specific files.

Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2025
@ashwindasr
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2025

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhadvig jhadvig added qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Apr 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 7, 2025

@ashwindasr: This pull request references ART-12521 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Image build was failing on Konflux due to missing go mod dependencies.

2025-04-04 17:29:46,063 ERROR vendor directory changed after vendoring:
A	vendor/golang.org/x/sys/unix/dev_aix_ppc.go
A	vendor/golang.org/x/sys/unix/dev_aix_ppc64.go
A	vendor/golang.org/x/sys/unix/dev_zos.go
2025-04-04 17:29:50,718 ERROR PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.

Konflux ignores .gitignore files since its a possible security gap.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit cf1abd6 into openshift:main Apr 7, 2025
12 checks passed
@ashwindasr ashwindasr deleted the konflux-prefetch-update branch April 7, 2025 13:32
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console-operator
This PR has been included in build openshift-enterprise-console-operator-container-v4.20.0-202504080239.p0.gcf1abd6.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants