Fix validate PR check #481
Conversation
openshift-ci
bot
added
the
approved
| @@ -11,7 +11,7 @@ BASE_SHA=$(git ls-remote "https://github.com/openshift/configuration-anomaly-det | |||
| PR_SHA=$(git rev-parse HEAD) | |||
|
|
|||
| # Obtaining instances of files added in the PR | |||
| diff_files=$(git diff --name-status "$BASE_SHA" "$PR_SHA" | grep '^A' | awk '{print $2}') | |||
| diff_files=$(git diff --name-status "$BASE_SHA" "$PR_SHA" | (grep '^A' || true;) | awk '{print $2}') | |||
There was a problem hiding this comment.
| diff_files=$(git diff --name-status "$BASE_SHA" "$PR_SHA" | (grep '^A' || true;) | awk '{print $2}') | |
| diff_files=$(git diff --name-status "$BASE_SHA" "$PR_SHA" | { grep '^A' || true; } | awk '{print $2}') |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bergmannf, MateSaary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bergmannf, MateSaary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@MateSaary: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
=======================================
Coverage 31.92% 31.92%
=======================================
Files 36 36
Lines 2487 2487
=======================================
Hits 794 794
Misses 1632 1632
Partials 61 61 🚀 New features to boost your workflow:
|
What type of PR is this?
This PR should fix the validate PR check by avoiding erroring out due to no results from a grep operation.