e2e: Don't rely on order of inconsistent results #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TestInconsistentResult e2e test was relying on a certain order in which a test result is labeled. If the result order was swapped, even if it contained the same results, the test would fail. This patch fixes the test to accept either of the two possible orderings. Since there's only two, both are hardcoded and checked, if we ever have more combinations, we'll refactor the code so that it is more generic.
openshift-ci
bot
added
the
approved
|
@jhrozek: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhrozek, mrogers950 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TestInconsistentResult e2e test was relying on a certain order in
which a test result is labeled. If the result order was swapped, even if
it contained the same results, the test would fail.
This patch fixes the test to accept either of the two possible
orderings. Since there's only two, both are hardcoded and checked, if we
ever have more combinations, we'll refactor the code so that it is more
generic.